Add support of Mercure running on a subdomain#1394
Conversation
|
I replaced the |
martineiber
left a comment
There was a problem hiding this comment.
Thanks for your PR!
I just have a small suggestion to improve readability.
Co-authored-by: Martin Eiber <martin.eiber@gmail.com>
|
Co-authored-by: JiaJia Ji <kingjia90@gmail.com>
|
|
@kingjia90 @martineiber can we merge this one? |
|
@martineiber is that is necessary? we need to adapt the direct-edit in case |
I do not see why it should be necessary. And can be removed. From my point this looks good. |
|
@bluvulture @vrobert78 Can we merge this one from you side? |
|
lgtm 👍 |



On Pimcore PaaS, we'd like to switch from running Mercure in a side app to running Mercure as a Service.
But running Mercure as a Service implies that we run it on a subdomain.
Those modifications are required for the authentication layer.
There are also changes required in studio-ui-bundle, see pimcore/studio-ui-bundle#2095.