-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create interactive command for curses interface (for discussion purposes) #66
Open
Pi2048
wants to merge
9
commits into
pimutils:main
Choose a base branch
from
Pi2048:interactive-mode
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a2b1aac
Create interactive command for curses interface
01d7556
squashme: minor cleanups
c5524a3
Mass renaming
untitaker ed4dc01
Fix up docstring types
untitaker 94f991e
Remove superfluous exit
untitaker 123461e
More code cleanup
untitaker 0a5d438
Replace list with tuple
untitaker 271bd43
Replace leftover signatures
untitaker a04aa5a
Fixup
untitaker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -530,7 +530,8 @@ def __init__(self, databases, formatter): | |
Create a Main instance based on the Database objects that | ||
the regular Todoman cli module passes. | ||
|
||
(Main, [Database], TodoFormatter) -> None | ||
:type databases: list[Database] | ||
:type formatter: TodoFormatter | ||
''' | ||
self.databases = databases | ||
# self.databases.sort(key = lambda db: db.name) | ||
|
@@ -551,7 +552,7 @@ def unhandled_input(self, key): | |
''' | ||
Handles all the key presses that are application-wide. | ||
|
||
(Main, str) -> None | ||
:type key: str | ||
''' | ||
if key in ('q', 'Q'): | ||
raise urwid.ExitMainLoop() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. When editing an entry, if a checkbox if focus and I press q, it immediately exists, without any confirmation, etc. |
||
|
@@ -561,7 +562,7 @@ def _open_page(self, page_to_open): | |
Open a page over the existing stack of pages. page_to_open is the | ||
Page object to display. | ||
|
||
(Main, Page) -> None | ||
:type page_to_open: Page | ||
''' | ||
self.loop.widget = urwid.Overlay( | ||
page_to_open, | ||
|
@@ -578,7 +579,7 @@ def close_page(self, page, **kwargs): | |
|
||
Usually called from the page to be closed. | ||
|
||
(Main, Page, **kwargs) -> None | ||
:type page: Page | ||
''' | ||
if self.pageCounter <= 1: | ||
raise urwid.ExitMainLoop() | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We still need to change this, because with the current model it doesn't make sense to pass a list of
Database
s.