Fix: PineconeGrpcFuture blocks during construction #478
+3
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using grpc with
async_req=True
, the construction of aPineconeGrpcFuture
would call_sync_state
, which would do a blocking call togrpc_future.exception(...)
. This means that the async reqs were all blocking in practice.Describe the purpose of this change. What problem is being solved and why?
Solution
We can fix it by checking if the future is still running and not doing any blocking calls when it is.
Type of Change
Test Plan
How I tested it:
PineconeGrpcFuture()
.result()
call instead.