exclude UNMAP,SECONDARY,QCFAIL,DUP,SUPPLEMENTARY #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ciency calculation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code only exclude the UNMAP reads from calculating edit efficiency of on/off targets, I think we should exclude the following reads as well .
SECONDARY: this is not a primary mapping position of this read.
QCFAIL: QC failed reads should be dropped.
DUP: duplicated reads should be dropped.
SUPPLEMENTARY: this is not the major mapping part of this read.
I think use the above reads might lead to some misleading of the calculation.