Skip to content

Azure private link support #20873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 22 commits into
base: support-azure
Choose a base branch
from
Open

Azure private link support #20873

wants to merge 22 commits into from

Conversation

nicole-yc
Copy link

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Apr 28, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 28, 2025

Hi @nicole-yc. Thanks for your PR.

I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added area/develop This PR relates to the area of TiDB App development. missing-translation-status This PR does not have translation status info. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 28, 2025
@gemini-code-assist gemini-code-assist
Copy link

Warning

Gemini encountered an error creating the summary. You can try again by commenting /gemini summary.

@qiancai qiancai changed the base branch from master to support-azure April 29, 2025 01:00
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 29, 2025
@qiancai qiancai self-assigned this Apr 29, 2025
nicole-yc
nicole-yc commented Apr 29, 2025
View reviewed changes
Copy link
Author

@nicole-yc nicole-yc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qiancai @qqqdan @tennix @cwen0 please take a look. thanks!

tennix
tennix reviewed Apr 29, 2025
View reviewed changes
tidb-cloud/set-up-private-endpoint-connections-on-azure.md

TiDB Cloud supports highly secure and one-way access to the TiDB Cloud service hosted in an Azure VNET via the [Azure Private Link](https://learn.microsoft.com/en-us/azure/private-link/private-link-overview), as if the service were in your own VNET. A private endpoint is exposed in your VNET and you can create a connection to the TiDB Cloud service via the endpoint with permission.

Powered by Azure Private Link, the endpoint connection is secure and private, and does not expose your data to the public internet. In addition, the endpoint connection supports CIDR overlap and is easier for network management.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's necessary to mention CIDR overlapping here.

Copy link
Author

@nicole-yc nicole-yc Apr 30, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will keep this because the sentence is same as AWS and GCP. Thanks！

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from qiancai, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

qiancai
qiancai reviewed Apr 30, 2025
View reviewed changes
tidb-cloud/set-up-private-endpoint-connections-on-azure.md Outdated

After you have accepted the endpoint connection, you are redirected back to the connection dialog.

1. Wait for the private endpoint connection status to become Active (approximately 5 minutes).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the user need to go to the Networking page to check if the private endpoint connection is active?

nicole-yc and others added 6 commits April 30, 2025 12:44
nicole-yc and others added 12 commits April 30, 2025 12:46
@nicole-yc @qiancai
Update tidb-cloud/set-up-private-endpoint-connections-on-azure.md
45db46d 
Co-authored-by: Grace Cai <[email protected]>
@nicole-yc @qiancai
Update tidb-cloud/set-up-private-endpoint-connections-on-azure.md
bcdc47e 
Co-authored-by: Grace Cai <[email protected]>
@nicole-yc @qiancai
Update tidb-cloud/set-up-private-endpoint-connections-on-azure.md
1f4dece 
Co-authored-by: Grace Cai <[email protected]>
@nicole-yc @qiancai
Update tidb-cloud/set-up-private-endpoint-connections-on-azure.md
f2d1625 
Co-authored-by: Grace Cai <[email protected]>
@nicole-yc @qiancai
Update tidb-cloud/set-up-private-endpoint-connections-on-azure.md
41cbba5 
Co-authored-by: Grace Cai <[email protected]>
@nicole-yc @qiancai
Update tidb-cloud/set-up-private-endpoint-connections-on-azure.md
bc19146 
Co-authored-by: Grace Cai <[email protected]>
@nicole-yc @qiancai
Update tidb-cloud/set-up-private-endpoint-connections-on-azure.md
1b216b1 
Co-authored-by: Grace Cai <[email protected]>
@nicole-yc
commit after rework
2c9cc85
@nicole-yc
commit after rework again
c5e8d6c
@nicole-yc
commit after rework again again
21c46db
@nicole-yc
Update set-up-private-endpoint-connections-on-azure.md
702c1bf
@nicole-yc
Update set-up-private-endpoint-connections-on-azure.md
c7e4d7d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tennix tennix tennix left review comments

@cwen0 cwen0 cwen0 left review comments

@qiancai qiancai qiancai left review comments

Assignees

@qiancai qiancai

Labels
area/develop This PR relates to the area of TiDB App development. contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. missing-translation-status This PR does not have translation status info. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nicole-yc @tennix @cwen0 @qiancai