-
Notifications
You must be signed in to change notification settings - Fork 702
planner: add group ndv risk variables #21654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Wenqi Mou <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @Tristan1900, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces documentation for a new TiDB optimizer variable, tidb_opt_group_ndv_skew_ratio. This variable provides fine-grained control over how the query optimizer estimates the Number of Distinct Values (NDV) for grouped data, allowing users to adjust the balance between different estimation methods. This enhancement aims to offer more flexibility in optimizing query plans, potentially leading to improved performance for specific workloads.
Highlights
- New Optimizer Variable Documentation: Added documentation for tidb_opt_group_ndv_skew_ratio, a new system variable introduced in TiDB v9.0.0. This variable controls the ratio between naive estimation and exponential backoff estimation for group Number of Distinct Values (NDV), allowing for a weighted combination of these methods.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
wait till #21339 get merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds documentation for the new system variable tidb_opt_group_ndv_skew_ratio
. The added content is clear and follows the document's structure. I've suggested a minor wording improvement to make the description more concise and easier to read.
- Type: Float | ||
- Range: `[0, 1]` | ||
- Default value: `0` | ||
- This variable controls the ratio between naive estimation and exponential backoff estimation for group NDV (Number of Distinct Values). When set to `0`, it uses naive estimation. When set to `1`, it uses exponential backoff estimation. Values between `0` and `1` provide a weighted combination of both estimation methods. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better readability and conciseness, you can combine the description of this variable into a single sentence. This avoids repeating "estimation" and "When set to".1
- This variable controls the ratio between naive estimation and exponential backoff estimation for group NDV (Number of Distinct Values). When set to `0`, it uses naive estimation. When set to `1`, it uses exponential backoff estimation. Values between `0` and `1` provide a weighted combination of both estimation methods. | |
- This variable controls the ratio between naive estimation and exponential backoff for group NDV (Number of Distinct Values): `0` for naive estimation, `1` for exponential backoff, and values in between for a weighted combination of both. |
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?