Tolerate unsupported persisted provider kinds#1507
Open
juliusmarminge wants to merge 1 commit intomainfrom
Open
Tolerate unsupported persisted provider kinds#1507juliusmarminge wants to merge 1 commit intomainfrom
juliusmarminge wants to merge 1 commit intomainfrom
Conversation
- Coerce legacy or future provider values during orchestration event reads - Accept non-empty persisted provider names in session directories - Add a shared provider support guard in contracts
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Why
UI Changes
Checklist
Note
Medium Risk
Changes event/session decoding to no longer fail on unknown provider strings, which could mask bad data and affect downstream provider dispatch if callers don’t re-validate.
Overview
Makes persisted reads tolerant of legacy/future provider values instead of failing strict schema decoding.
On orchestration event replay (
OrchestrationEventStore.readFromSequence), the payload’smodelSelection/defaultModelSelectionprovider is coerced toDEFAULT_PROVIDER_KINDwhenisSupportedProviderrejects it, ensuringOrchestrationEventdecoding succeeds.For provider session directory bindings, persisted provider names now accept any non-empty string (cast to
ProviderKind) rather than rejecting unknown providers, and contracts add a sharedisSupportedProviderguard for callers to explicitly check support.Written by Cursor Bugbot for commit 415a840. This will update automatically on new commits. Configure here.
Note
Tolerate unsupported persisted provider kinds when reading orchestration events
coerceUnsupportedProvidersinOrchestrationEventStoreto patchmodelSelection/defaultModelSelectionpayloads that contain unknown provider names, replacing them withDEFAULT_PROVIDER_KINDbefore schema decoding.isSupportedProvidertype guard inorchestration.tsto test whether a provider string is'codex'or'claudeAgent'.decodeProviderKindinProviderSessionDirectoryto accept any non-empty provider string instead of only known kinds.Macroscope summarized 415a840.