fix(web): work log Show more — cursor, transition & scroll#1569
fix(web): work log Show more — cursor, transition & scroll#1569Marve10s wants to merge 10 commits intopingdotgg:mainfrom
Conversation
The raw <button> element was missing cursor-pointer, causing the default arrow cursor on hover instead of the expected hand pointer.
Use the existing Base UI Collapsible component to animate the overflow entries in tool call / work log groups with a 200ms height transition instead of an instant show/hide.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
59c3df1 to
8e290fc
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Expanding a work log group during a running session would trigger scheduleStickToBottom via the timelineEntries effect, yanking the viewport to the bottom. Disable auto-scroll on toggle so the user stays where they clicked; the scroll-to-bottom button is shown if they want to jump back.
954a90d to
8caccfb
Compare
2026-03-30.12.07.23.mp4Sorry, took a second for Codex and I also needed to approve access to folders for Claude :) |
scroll behavior is kinda jank when it sometimes expands up and sometimes down. your scroll position shouldn't change when expanding: CleanShot.2026-04-06.at.10.44.49.mp4 |
I can address that in next commit if you're okay with this change overall |
|
I didn't test it out but overall seems like a solid change except for that yes |
|
@juliusmarminge should be good to go , not sure if I should tag you or if you'd come back to this PR eventually. Thank you for reviewing and helping make the software better |
ApprovabilityVerdict: Approved This is a focused UI fix for scroll behavior when expanding/collapsing work log entries - prevents unwanted scroll jumps by canceling auto-scroll and opting out of scroll anchoring. The changes use existing Collapsible components, include test coverage, and the author has recent history with these files. You can customize Macroscope's approvability policy. Learn more. |

Summary
cursor-pointer, showing a default arrow on hover instead of a hand. Fixed by switching to the existingCollapsibleTriggercomponent which includes it.Collapsible+CollapsiblePanelcomponent, giving a smooth 200ms height animation when expanding/collapsing overflow entries.scheduleStickToBottom. Now disables auto-scroll on toggle so the user stays where they clicked; the scroll-to-bottom button appears if they want to jump back.Note
Low Risk
Low risk UI behavior changes limited to chat work-log expansion and scroll anchoring; main risk is subtle scroll/virtualization regressions on different browsers.
Overview
Improves chat work-log/tool-call group expansion by switching the overflow section to the existing
Collapsible/CollapsiblePanelcomponents, enabling pointer cursor on the trigger and a smooth height animation while keeping hidden entries mounted.Prevents unexpected viewport jumps when expanding/collapsing by opting the messages scroller out of browser scroll anchoring (
overflowAnchor: "none"), marking the trigger withdata-scroll-anchor-ignore, and disabling/canceling auto-stick-to-bottom when toggling a work group (showing the scroll-to-bottom pill instead). Adds a regression test for the scroll-anchor ignore attribute.Reviewed by Cursor Bugbot for commit 6e135ca. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix work log 'Show more' cursor, transition, and scroll behavior in chat
Collapsible/CollapsiblePanelpattern; overflow entries stay mounted while collapsed so they animate correctly on expand.data-scroll-anchor-ignoreto the expand/collapse trigger so browser scroll anchoring ignores it.overflowAnchor: "none".Macroscope summarized 6e135ca.