Skip to content

fix(web): work log Show more — cursor, transition & scroll#1569

Open
Marve10s wants to merge 10 commits intopingdotgg:mainfrom
Marve10s:fix/show-more-cursor-and-transition
Open

fix(web): work log Show more — cursor, transition & scroll#1569
Marve10s wants to merge 10 commits intopingdotgg:mainfrom
Marve10s:fix/show-more-cursor-and-transition

Conversation

@Marve10s
Copy link
Copy Markdown
Contributor

@Marve10s Marve10s commented Mar 30, 2026

Summary

  • Cursor pointer: The "Show more" button in work log / tool call groups was missing cursor-pointer, showing a default arrow on hover instead of a hand. Fixed by switching to the existing CollapsibleTrigger component which includes it.
  • Smooth transition: Replaced the instant show/hide with the existing Base UI Collapsible + CollapsiblePanel component, giving a smooth 200ms height animation when expanding/collapsing overflow entries.
  • No auto-scroll on expand: Expanding a work log group during a running session would yank the viewport to the bottom via scheduleStickToBottom. Now disables auto-scroll on toggle so the user stays where they clicked; the scroll-to-bottom button appears if they want to jump back.

Note

Low Risk
Low risk UI behavior changes limited to chat work-log expansion and scroll anchoring; main risk is subtle scroll/virtualization regressions on different browsers.

Overview
Improves chat work-log/tool-call group expansion by switching the overflow section to the existing Collapsible/CollapsiblePanel components, enabling pointer cursor on the trigger and a smooth height animation while keeping hidden entries mounted.

Prevents unexpected viewport jumps when expanding/collapsing by opting the messages scroller out of browser scroll anchoring (overflowAnchor: "none"), marking the trigger with data-scroll-anchor-ignore, and disabling/canceling auto-stick-to-bottom when toggling a work group (showing the scroll-to-bottom pill instead). Adds a regression test for the scroll-anchor ignore attribute.

Reviewed by Cursor Bugbot for commit 6e135ca. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix work log 'Show more' cursor, transition, and scroll behavior in chat

  • Replaces slice-based show/hide in MessagesTimeline.tsx with a Collapsible/CollapsiblePanel pattern; overflow entries stay mounted while collapsed so they animate correctly on expand.
  • Adds data-scroll-anchor-ignore to the expand/collapse trigger so browser scroll anchoring ignores it.
  • In ChatView.tsx, toggling a work log group now cancels pending stick-to-bottom, disables auto-scroll, and shows the scroll-to-bottom button. The messages container also opts out of browser scroll anchoring via overflowAnchor: "none".
  • Behavioral Change: work log overflow entries remain in the DOM when collapsed, which is a change from prior behavior where they were removed from the tree.

Macroscope summarized 6e135ca.

The raw <button> element was missing cursor-pointer, causing the
default arrow cursor on hover instead of the expected hand pointer.
Use the existing Base UI Collapsible component to animate the overflow
entries in tool call / work log groups with a 200ms height transition
instead of an instant show/hide.
@github-actions github-actions bot added size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Mar 30, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 30, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 03a4a103-c60a-4347-82bb-180531da3c33

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Marve10s Marve10s force-pushed the fix/show-more-cursor-and-transition branch from 59c3df1 to 8e290fc Compare March 30, 2026 09:13
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Expanding a work log group during a running session would trigger
scheduleStickToBottom via the timelineEntries effect, yanking the
viewport to the bottom. Disable auto-scroll on toggle so the user
stays where they clicked; the scroll-to-bottom button is shown if
they want to jump back.
@Marve10s Marve10s force-pushed the fix/show-more-cursor-and-transition branch from 954a90d to 8caccfb Compare March 30, 2026 09:29
@Marve10s
Copy link
Copy Markdown
Contributor Author

2026-03-30.12.07.23.mp4

Sorry, took a second for Codex and I also needed to approve access to folders for Claude :)

@juliusmarminge
Copy link
Copy Markdown
Member

2026-03-30.12.07.23.mp4
Sorry, took a second for Codex and I also needed to approve access to folders for Claude :)

scroll behavior is kinda jank when it sometimes expands up and sometimes down. your scroll position shouldn't change when expanding:

CleanShot.2026-04-06.at.10.44.49.mp4

@Marve10s
Copy link
Copy Markdown
Contributor Author

Marve10s commented Apr 6, 2026

2026-03-30.12.07.23.mp4
Sorry, took a second for Codex and I also needed to approve access to folders for Claude :)

scroll behavior is kinda jank when it sometimes expands up and sometimes down. your scroll position shouldn't change when expanding:
CleanShot.2026-04-06.at.10.44.49.mp4

I can address that in next commit if you're okay with this change overall

@juliusmarminge
Copy link
Copy Markdown
Member

I didn't test it out but overall seems like a solid change except for that yes

@Marve10s
Copy link
Copy Markdown
Contributor Author

Marve10s commented Apr 6, 2026

@juliusmarminge should be good to go , not sure if I should tag you or if you'd come back to this PR eventually. Thank you for reviewing and helping make the software better
Also, is there anything I can help with in your draft PRs or any tasks? I'd love to set up T3 on my WSL, saw a draft for this some time ago, right now I'm only running it on Mac

@macroscopeapp
Copy link
Copy Markdown
Contributor

macroscopeapp bot commented Apr 6, 2026

Approvability

Verdict: Approved

This is a focused UI fix for scroll behavior when expanding/collapsing work log entries - prevents unwanted scroll jumps by canceling auto-scroll and opting out of scroll anchoring. The changes use existing Collapsible components, include test coverage, and the author has recent history with these files.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants