Skip to content

Refactor open service onto Effect-backed process spawning #1603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juliusmarminge wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Refactor open service onto Effect-backed process spawning #1603

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
2ade037
Refactor open service onto Effect-backed process spawning
juliusmarminge Mar 31, 2026
d7257df
Extract desktop launcher service layer
juliusmarminge Mar 31, 2026
d358a66
Merge origin/main into t3code/open-service-effect-api
juliusmarminge Mar 31, 2026
7fa5304
Detach direct app launches on Windows when not waiting
juliusmarminge Mar 31, 2026
439e8bc
Preserve waited app launch exit errors
juliusmarminge Mar 31, 2026
935e7c6
Refactor process helpers for Windows handling and output limits
juliusmarminge Mar 31, 2026
0cdb35e
Skip WSL browser launch in containers
juliusmarminge Mar 31, 2026
c547247
fix: detect immediate exit failures in detached launches and handle e…
cursoragent Mar 31, 2026
9b3394c
rm aliases
juliusmarminge Mar 31, 2026
72c3478
naming
juliusmarminge Mar 31, 2026
1218eff
Launch Windows shims through PowerShell Start-Process
juliusmarminge Mar 31, 2026
8d257e2
Open VS Code on Windows via protocol URI
juliusmarminge Apr 11, 2026
b909b94
progress?
juliusmarminge Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion apps/server/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
"@pierre/diffs": "^1.1.0-beta.16",
"effect": "catalog:",
"node-pty": "^1.1.0",
"open": "^10.1.0",
"ws": "^8.18.0"
},
"devDependencies": {
Expand Down
2 changes: 2 additions & 0 deletions apps/server/src/main.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ const testLayer = Layer.mergeAll(
stopSignal: Effect.void,
} satisfies ServerShape),
Layer.succeed(Open, {
getAvailableEditors: Effect.succeed([]),
openExternal: () => Effect.void,
openBrowser: (_target: string) => Effect.void,
openInEditor: () => Effect.void,
} satisfies OpenShape),
Expand Down
Loading
Loading