feat: added terminal docking to right#1774
feat: added terminal docking to right#1774atmikshetty wants to merge 4 commits intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Needs human review This PR adds a new user-facing feature (terminal docking to right side) with new state properties, storage migration logic, and UI layout changes. While well-tested and scoped to the terminal drawer area, new features introducing user-facing behavior warrant human review. You can customize Macroscope's approvability policy. Learn more. |
juliusmarminge
left a comment
There was a problem hiding this comment.
probably wanna support vertical splits with this as well?
|
Yes, that should be added as well. @juliusmarminge should I implement this? |
|
Go for it! |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ea5a7fd. Configure here.

What Changed
Why
UI Changes
Terminal Docked to the right:

Works when the app is minimised as well:

Redocking back to below the chat:

Small Video showing the full change:
https://github.com/user-attachments/assets/3a6f0f84-5040-4dd1-b139-7c2e94650050
Checklist
Note
Medium Risk
Moderate UI/state changes: introduces persisted terminal dock/width with a storage migration and alters terminal resize/open behavior, which could regress layout or terminal sizing across existing users.
Overview
Adds a dock toggle to the thread terminal drawer so terminals can be displayed either below the chat view or docked to the right, including right-side resize handling and updated split-pane layout when docked right.
Persists the new per-thread
terminalDockandterminalWidthin the terminal Zustand store (with a storage version bump + migration/normalization), updatesChatViewto render right-docked drawers alongside the main content while keeping bottom-docked drawers below, and extends tests to cover dock/width behavior.Additionally, the desktop
electron-launchernow attempts to automatically run Electron’sinstall.jswhenrequire('electron')fails with the known “failed to install correctly” error, andpackage.jsonmarkselectronas a trusted dependency.Reviewed by Cursor Bugbot for commit 4f328b1. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add right-side docking to the terminal drawer
ThreadTerminalDrawerso users can switch the terminal between bottom and right-side docking.terminalDockandterminalWidthtoThreadTerminalState, persisted per thread and migrated from legacy snapshots. Closing the last terminal now preserves dock/size preferences.ChatViewpartitions mounted terminal drawers by dock position and renders right-docked terminals alongside the main layout, bottom-docked terminals below.clampTerminalDockWidthandresolveTerminalSplitGridStylehelpers to constrain right-dock widths and switch split-terminal grid orientation based on dock side.selectThreadTerminalStatenow normalizes returned state, which may differ from raw persisted values for older stored states.Macroscope summarized 4f328b1.