-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: composable primitive components #947
Open
veloii
wants to merge
43
commits into
pingdotgg:main
Choose a base branch
from
veloii:without-dropzone-package
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
ad67fd0
feat: primitive components
veloii bd7475f
feat: controllable files in primitive components
veloii e67ae68
Merge branch 'pingdotgg:main' into main
veloii a184147
refactor: remove dead code
veloii b1c57d9
feat: primitive clear button
veloii 90ab08f
refactor: button component to use primitives
veloii 1eb1b31
feat: wrap primitive allowed content in a div
veloii f2d191d
feat: `as` prop & ref support in primitive components
veloii 7a26a1a
style: prefix generics with `T` for consistency
veloii f546640
fix: add the 'use client' directive to primitive components
veloii 5f12570
refactor: dropzone component to use primitives
veloii 1dc0a96
Merge branch 'main' into without-dropzone-package
veloii 4a9abce
todo: remove redundant import
veloii 3739b2d
todo: re-add use dropzone hook into primitive dropzone
veloii 314da61
style: consistency with import type statements
veloii 6a395b1
chore: add basic styling to the examples
veloii 1d4d5c2
chore: `onCompleteUploadComplete` and `onUploadBegin` props added for…
veloii 12be484
fix: disabled accessibility for primitive button components
veloii 29469b3
fix: useUncontrolledState potential issue with falsy value
veloii d1dd53c
fix: dropzone and button components not using custom cn
veloii 1330c72
refactor: button component to use `rootProps` variable name for consi…
veloii 753c95d
refactor: use more precise function type for `RefProp`
veloii fc72978
perf: optimise useEffect deps in the root primitive component
veloii 3c1d7dc
remove redundant type guards in the root primitive component
veloii f9bb2a8
fix: root primitive syntax
veloii 3b51eaa
feat: disabled prop on dropzone primitive
veloii 46678ec
fix: allow undefined on disabled prop
veloii a7b146a
fix: internal component props
veloii 1fea662
fix: add disabled check on primitive button on click
veloii 07424f3
fix: usePaste hook in primtive root not auto uploading the pasted files
veloii 3b8a366
chore: remove redundant import in root primitve
veloii 8faf68f
fix: backwards compat with onDrop prop
veloii 444237b
Merge branch 'main' into without-dropzone-package
veloii f49d5c6
fix: merge conflicts
veloii 24082c7
fix: examples to use state instead of isUploading
veloii 08dbf99
docs: unstyled primitive components
veloii b601196
fix: add disabled prop to clear button
veloii b140b50
fix: add disabled prop to button
veloii 7d38176
Update packages/react/src/components/primitive/root.tsx
veloii c18d02c
fix: import useMemo
veloii aac8916
docs: unstyled primitive components usage
veloii 6d86f6e
Merge branch 'main' into without-dropzone-package
juliusmarminge 11f77eb
more docs
juliusmarminge File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Enhance button loading state feedback.
The button's state indication could be more informative. Consider adding a loading spinner and disabled state during upload.