chore: add tests for #964

[juliusmarminge]

Test and Changeset for #964 since the branch was protected

Summary by CodeRabbit

• New Features

  • Enhanced user interface for the UploadDropzone component with dynamic labeling based on file selection capabilities.

• Bug Fixes

  • Improved pluralization in the UploadButton component's label based on the number of files selected.

• Tests

  • Added new tests for the UploadButton and UploadDropzone components to ensure correct behavior and labeling under various conditions, including handling of multiple file uploads.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-uploadthing	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 20, 2024 7:03am

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
legacy-docs-uploadthing	⬜️ Skipped (Inspect)			Sep 20, 2024 7:03am

[github-actions]

📦 Bundle size comparison

Bundle	Size (gzip)	Visualization
Main	26.03KB	See Treemap 📊
PR (6128d1a)	26.03KB	See Treemap 📊
Diff	No change

[coderabbitai]

Walkthrough

The changes consist of enhancements to the UploadDropzone and UploadButton components in a React application. The UploadDropzone component's label text is updated to reflect whether users can select a single file or multiple files based on the multiple prop. Additionally, new tests are introduced for both components to ensure correct label display and behavior under various conditions, including pluralization for file selection. A new test file for UploadDropzone is also created to validate its functionality and interaction with a mock API.

Changes

File	Change Summary
packages/react/src/components/dropzone.tsx	Updated label text in UploadDropzone to reflect single or multiple file selection.
packages/react/test/upload-button.test.tsx	Added new test for pluralization of label in UploadButton; removed commented-out expectation.
packages/react/test/upload-dropzone.test.tsx	Introduced new tests for UploadDropzone, validating its behavior and API interactions.
examples/backend-adapters/test/smoke.test.ts	Simplified file input label selection method in smoke tests without altering functionality.

Possibly related PRs

• chore: Fix wrong dropzone label #964: The changes in this PR also focus on refining the label text in the UploadDropzone component to accurately reflect whether users can select a single file or multiple files, directly aligning with the modifications made in the main PR.

Poem

In the meadow where uploads play,
A dropzone dances, bright as day.
With labels that shift, oh what a sight,
Choose files with joy, all feels just right!
Tests now guard this joyful place,
Ensuring each file finds its space! 🐇✨

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9bb67bc and 70cdf27.

Files selected for processing (1)

• examples/backend-adapters/test/smoke.test.ts (3 hunks)

Additional comments not posted (3)

examples/backend-adapters/test/smoke.test.ts (3)

18-18: Verify the assumption that the desired label is always the first one.

The change simplifies the code by directly clicking the first label element instead of filtering by text. This assumes that the desired label is always the first one.

Please verify this assumption holds true in all scenarios. If confirmed, the change looks good.

---

38-38: The same assumption needs to be verified for this test case.

Please ensure that the assumption discussed in the previous test case (the desired label always being the first one) holds true for this test case as well.

---

61-61: The same assumption needs to be verified for this test case.

Please ensure that the assumption discussed in the previous test cases (the desired label always being the first one) holds true for this test case as well.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[pkg-pr-new]

Open in Stackblitz

More templates

• @example/minimal-appdir
• @example/minimal-astro-react
• @example/minimal-expo
• @example/minimal-nuxt
• @example/minimal-pagedir
• @example/minimal-solidstart
• @example/minimal-sveltekit

pnpm add https://pkg.pr.new/pingdotgg/uploadthing/@uploadthing/react@966

commit: 70cdf27

[changeset-bot]

🦋 Changeset detected

Latest commit: 70cdf27

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@uploadthing/react	Patch
@uploadthing/expo	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[juliusmarminge]

gonna merge as CI is currently blocked on the playwright test