chore: Add MCP protocol compliance enforcement and documentation #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes MCP protocol compliance violations in authentication wrapper code where fmt.Printf was causing protocol communication issues. Changes: - Replaced all fmt.Printf calls in internal/auth/client/wrapper.go with structured logging using log.Info - Fixed cmd/session/session.go to use correct fmt.Printf for CLI output (CLI commands are exempt from MCP logging restrictions) - Removed format strings, newlines, and trailing punctuation from log messages to follow MCP structured logging patterns This ensures the MCP server's authentication flows properly use structured logging as required by the MCP specification, preventing interference with protocol communication on stdout/stderr.
- Add golangci-lint forbidigo linter to prevent fmt.Printf in MCP server code - Add comprehensive MCP compliance documentation - Update contributing guides with MCP specification requirements - Add Makefile targets for MCP spec validation - Exemptions properly configured for CLI commands and test files This housekeeping change prevents future MCP protocol violations by providing automated checks and clear documentation for contributors.
patrickcping
requested a review
from henryrecker-pingidentity
as a code owner
Base automatically changed from
fix/auth-wrapper-logging-mcp-protocol/pc/20251212
to
main
December 12, 2025 15:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds automated enforcement mechanisms and comprehensive documentation to prevent future MCP protocol compliance violations. This housekeeping PR complements PR #35 by ensuring contributors don't accidentally introduce fmt.Printf calls in MCP server code.
Changes
New Files
.golangci.yml: golangci-lint configuration with forbidigo linter to block fmt.Printf/println in MCP server code.github/copilot-instructions.md: Comprehensive development guide (250+ lines) covering:docs/mcp-specification-compliance.md: Detailed MCP compliance documentationModified Files
Makefile: Addedmcp-spec-checkandvalidate-alltargets for validationCONTRIBUTING.md: Added MCP Specification Compliance sectioncontributing/pr-checklist.md: Added MCP compliance verification stepsEnforcement Strategy
The forbidigo linter automatically exempts appropriate locations:
cmd/directory - CLI commands can use fmt.Printf*_test.go)internal/errs/- Error formattinginternal/logger/- Logger implementationAnd blocks fmt.Printf in MCP server code:
internal/serverinternal/toolsinternal/sdkinternal/auth/client,internal/auth/login,internal/auth/logoutType of Change
Testing
Makefile Targets Validation
Lint Check
make lint # Now includes forbidigo linter checkChecklist
Related PRs
Additional Context
This is part 2 of a 2-part change:
The lint checks will catch violations during development and in CI, providing clear guidance to contributors about where fmt.Printf is and isn't allowed.