pingone_davinci_application_flow_policy beta resource #1172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be expanded when flow resource is available
patrickcping
approved these changes
Dec 16, 2025
Collaborator
patrickcping
left a comment
patrickcping
left a comment
There was a problem hiding this comment.
Some minor comments, then good to merge once all the TODO markers are rounded out
internal/service/davinci/resource_davinci_application_flow_policy_gen.go
Outdated
Show resolved
Hide resolved
| stringplanmodifier.RequiresReplace(), | ||
| }, | ||
| }, | ||
| "environment_id": schema.StringAttribute{ |
Collaborator
There was a problem hiding this comment.
We have framework.Attr_LinkID() for consistency
| resp.Schema = schema.Schema{ | ||
| Description: "Resource to create and manage a DaVinci application flow policy.", | ||
| Attributes: map[string]schema.Attribute{ | ||
| "da_vinci_application_id": schema.StringAttribute{ |
Collaborator
There was a problem hiding this comment.
If this is a DaVinci ID, we have a custom type that makes these consistent
| "flow_distributions": schema.SetNestedAttribute{ | ||
| NestedObject: schema.NestedAttributeObject{ | ||
| Attributes: map[string]schema.Attribute{ | ||
| "id": schema.StringAttribute{ |
Collaborator
There was a problem hiding this comment.
This is a foreign key of the flow resource, it probably would benefit from the DaVinci ID custom type
| setvalidator.SizeBetween(1, 100), | ||
| }, | ||
| }, | ||
| "id": schema.StringAttribute{ |
Collaborator
There was a problem hiding this comment.
We have the framework.Attr_ID for consistency
| version = 1 | ||
| weight = 100 | ||
| } | ||
| #TODO add a second flow |
| name = "Updated policy" | ||
| status = "disabled" | ||
| #TODO test trigger with a pingone flow | ||
| // trigger = { |
| } | ||
|
|
||
| // Maximal HCL with all values set, with ordering changes in lists and sets from the default CompleteHCL | ||
| // TODO update when the pingone_davinci_flow resource is available, reorder the updated CompleteHCL to form this |
| da_vinci_application_id = pingone_davinci_application.%[3]s.id | ||
| flow_distributions = [ | ||
| { | ||
| #TODO use flow resource to create this, rather than using a hardcoded id |
| } | ||
|
|
||
| // Validate any computed values when applying complete HCL | ||
| // TODO This may not be needed as a separate function from minimal HCL if the expected values match |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
pingone_davinci_application_flow_policyresource. Currently targeted at theDavinciApplicationResourcebranch for a cleaner diff.pingone_davinci_applicationinto a separate fileChange Characteristics
Checklist
All full (or complete) PRs that need review prior to merge should have the following box checked.
If contributing a partial or incomplete change (expecting the development team to complete the remaining work) please leave the box unchecked
Required SDK Upgrades
Testing
This PR has been tested with:
Shell Command(s)
Tests rely on changes in later flow branch. I'll attach test results from testing on that branch.
Testing Results
Expand Results
End-to-end Tests Workflow Links