DaVinci beta data sources #1174

henryrecker-pingidentity · 2025-12-01T22:01:12Z

Change Description

Add various beta data sources for DaVinci:

pingone_davinci_application
pingone_davinci_applications
pingone_davinci_connector
pingone_davinci_connectors
pingone_davinci_connector_instance
pingone_davinci_connector_instances

Change Characteristics

This PR contains beta functionality
This PR requires introduction of breaking changes
No changelog entry is needed

Checklist

All full (or complete) PRs that need review prior to merge should have the following box checked.

If contributing a partial or incomplete change (expecting the development team to complete the remaining work) please leave the box unchecked

Check to confirm: I have performed a review of my PR against the PR checklist and confirm that:
- The changelog entry has been included according to the changelog process
- Changes have proper test coverage (including regression tests)
- Impacted resource, data source and schema descriptions have been reviewed and updated
- Impacted resource and data source documentation HCL examples have been reviewed and updated
- Does not introduce breaking changes (unless required to do so)
- I am aware that changes to generated code may not be merged

Required SDK Upgrades

Testing

This PR has been tested with:

Unit tests (please paste commands and results below)
Acceptance tests (please paste commands and results below)
End-to-end tests (please paste the link to the actions workflow runs)
Not applicable (no evidences needed)

Shell Command(s)

TF_ACC=1 TESTACC_BETA=true go test -tags=beta -v -timeout 300s -run "^TestAccDavinci.*DataSource" github.com/pingidentity/terraform-provider-pingone/internal/service/davinci

Testing Results

Expand Results

=== RUN   TestAccDavinciApplicationDataSource_ByIDFull_Clean
=== PAUSE TestAccDavinciApplicationDataSource_ByIDFull_Clean
=== RUN   TestAccDavinciApplicationDataSource_ByIDFull_WithBootstrap
=== PAUSE TestAccDavinciApplicationDataSource_ByIDFull_WithBootstrap
=== RUN   TestAccDavinciApplicationDataSource_BootstrapApplicationByIDFull
=== PAUSE TestAccDavinciApplicationDataSource_BootstrapApplicationByIDFull
=== RUN   TestAccDavinciApplicationDataSource_NotFound_Clean
=== PAUSE TestAccDavinciApplicationDataSource_NotFound_Clean
=== RUN   TestAccDavinciApplicationDataSource_NotFound_WithBootstrap
=== PAUSE TestAccDavinciApplicationDataSource_NotFound_WithBootstrap
=== RUN   TestAccDavinciApplicationsDataSource_Get_Clean
=== PAUSE TestAccDavinciApplicationsDataSource_Get_Clean
=== RUN   TestAccDavinciApplicationsDataSource_Get_WithBootstrap
=== PAUSE TestAccDavinciApplicationsDataSource_Get_WithBootstrap
=== RUN   TestAccDavinciConnectorDataSource_ByIDFull_Clean
=== PAUSE TestAccDavinciConnectorDataSource_ByIDFull_Clean
=== RUN   TestAccDavinciConnectorDataSource_ByIDFull_WithBootstrap
=== PAUSE TestAccDavinciConnectorDataSource_ByIDFull_WithBootstrap
=== RUN   TestAccDavinciConnectorDataSource_NotFound
=== PAUSE TestAccDavinciConnectorDataSource_NotFound
=== RUN   TestAccDavinciConnectorInstanceDataSource_ByIDFull_Clean
=== PAUSE TestAccDavinciConnectorInstanceDataSource_ByIDFull_Clean
=== RUN   TestAccDavinciConnectorInstanceDataSource_ByIDFull_WithBootstrap
=== PAUSE TestAccDavinciConnectorInstanceDataSource_ByIDFull_WithBootstrap
=== RUN   TestAccDavinciConnectorInstanceDataSource_NotFound_Clean
=== PAUSE TestAccDavinciConnectorInstanceDataSource_NotFound_Clean
=== RUN   TestAccDavinciConnectorInstanceDataSource_NotFound_WithBootstrap
=== PAUSE TestAccDavinciConnectorInstanceDataSource_NotFound_WithBootstrap
=== RUN   TestAccDavinciConnectorInstanceDataSource_BootstrapConnectionByID_Clean
=== PAUSE TestAccDavinciConnectorInstanceDataSource_BootstrapConnectionByID_Clean
=== RUN   TestAccDavinciConnectorInstanceDataSource_BootstrapConnectionByID_WithBootstrap
=== PAUSE TestAccDavinciConnectorInstanceDataSource_BootstrapConnectionByID_WithBootstrap
=== RUN   TestAccDavinciConnectorInstancesDataSource_Get_Clean
=== PAUSE TestAccDavinciConnectorInstancesDataSource_Get_Clean
=== RUN   TestAccDavinciConnectorInstancesDataSource_Get_WithBootstrap
=== PAUSE TestAccDavinciConnectorInstancesDataSource_Get_WithBootstrap
=== RUN   TestAccDavinciConnectorsDataSource_Get_Clean
=== PAUSE TestAccDavinciConnectorsDataSource_Get_Clean
=== RUN   TestAccDavinciConnectorsDataSource_Get_WithBootstrap
=== PAUSE TestAccDavinciConnectorsDataSource_Get_WithBootstrap
=== CONT  TestAccDavinciApplicationDataSource_ByIDFull_Clean
=== CONT  TestAccDavinciConnectorInstanceDataSource_ByIDFull_Clean
=== CONT  TestAccDavinciApplicationsDataSource_Get_Clean
=== CONT  TestAccDavinciConnectorDataSource_ByIDFull_WithBootstrap
=== CONT  TestAccDavinciApplicationDataSource_NotFound_Clean
=== CONT  TestAccDavinciConnectorInstancesDataSource_Get_WithBootstrap
=== CONT  TestAccDavinciApplicationDataSource_NotFound_WithBootstrap
=== CONT  TestAccDavinciConnectorInstancesDataSource_Get_Clean
=== CONT  TestAccDavinciConnectorInstanceDataSource_NotFound_WithBootstrap
=== CONT  TestAccDavinciConnectorInstanceDataSource_BootstrapConnectionByID_Clean
=== CONT  TestAccDavinciApplicationsDataSource_Get_WithBootstrap
=== CONT  TestAccDavinciConnectorDataSource_ByIDFull_Clean
=== CONT  TestAccDavinciConnectorInstanceDataSource_BootstrapConnectionByID_WithBootstrap
=== CONT  TestAccDavinciConnectorDataSource_NotFound
=== CONT  TestAccDavinciConnectorsDataSource_Get_Clean
=== CONT  TestAccDavinciConnectorsDataSource_Get_WithBootstrap
--- PASS: TestAccDavinciApplicationDataSource_NotFound_WithBootstrap (5.30s)
=== CONT  TestAccDavinciConnectorInstanceDataSource_ByIDFull_WithBootstrap
--- PASS: TestAccDavinciConnectorInstanceDataSource_BootstrapConnectionByID_Clean (5.56s)
=== CONT  TestAccDavinciApplicationDataSource_BootstrapApplicationByIDFull
--- PASS: TestAccDavinciApplicationDataSource_NotFound_Clean (6.00s)
=== CONT  TestAccDavinciConnectorInstanceDataSource_NotFound_Clean
--- PASS: TestAccDavinciConnectorInstanceDataSource_NotFound_WithBootstrap (7.39s)
=== CONT  TestAccDavinciApplicationDataSource_ByIDFull_WithBootstrap
--- PASS: TestAccDavinciConnectorDataSource_NotFound (9.78s)
--- PASS: TestAccDavinciConnectorInstanceDataSource_BootstrapConnectionByID_WithBootstrap (13.34s)
--- PASS: TestAccDavinciConnectorDataSource_ByIDFull_WithBootstrap (13.53s)
--- PASS: TestAccDavinciConnectorInstanceDataSource_NotFound_Clean (7.73s)
--- PASS: TestAccDavinciConnectorInstancesDataSource_Get_WithBootstrap (14.95s)
--- PASS: TestAccDavinciApplicationDataSource_ByIDFull_Clean (15.06s)
--- PASS: TestAccDavinciConnectorDataSource_ByIDFull_Clean (15.52s)
--- PASS: TestAccDavinciConnectorInstanceDataSource_ByIDFull_Clean (15.82s)
--- PASS: TestAccDavinciApplicationsDataSource_Get_WithBootstrap (16.77s)
--- PASS: TestAccDavinciApplicationDataSource_BootstrapApplicationByIDFull (11.41s)
--- PASS: TestAccDavinciApplicationsDataSource_Get_Clean (17.17s)
--- PASS: TestAccDavinciConnectorInstancesDataSource_Get_Clean (17.40s)
--- PASS: TestAccDavinciApplicationDataSource_ByIDFull_WithBootstrap (10.27s)
--- PASS: TestAccDavinciConnectorInstanceDataSource_ByIDFull_WithBootstrap (14.52s)
--- PASS: TestAccDavinciConnectorsDataSource_Get_WithBootstrap (24.52s)
--- PASS: TestAccDavinciConnectorsDataSource_Get_Clean (25.64s)
PASS
ok  	github.com/pingidentity/terraform-provider-pingone/internal/service/davinci	26.433s

End-to-end Tests Workflow Links

Including filled-out test template

spjwks_url should be sp_jwks_url

…taSources

patrickcping

Some minor things to review, but once done LGTM 🚀 🚀

patrickcping · 2025-12-16T15:16:33Z

go.mod

 	github.com/patrickcping/pingone-go-sdk-v2/risk v0.21.0
 	github.com/patrickcping/pingone-go-sdk-v2/verify v0.10.0
-	github.com/pingidentity/pingone-go-client v0.2.0
+	github.com/pingidentity/pingone-go-client v0.3.1-0.20251117224159-0cf427981cb9


patrickcping · 2025-12-16T15:21:59Z

internal/service/davinci/data_source_davinci_application_gen.go

+		},
+		"GetDavinciApplicationById",
+		framework.DefaultCustomError,
+		framework.DefaultRetryable,


DefaultCreateReadRetryable

internal/service/davinci/data_source_davinci_application_gen_test.go

patrickcping · 2025-12-16T17:35:18Z

internal/service/davinci/data_source_davinci_applications_gen.go

+				},
+				Computed: true,
+			},
+			"environment_id": schema.StringAttribute{


patrickcping · 2025-12-16T17:35:23Z

internal/service/davinci/data_source_davinci_applications_gen.go

+					stringvalidator.RegexMatches(regexp.MustCompile("^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$"), "Must be a valid UUID"),
+				},
+			},
+			"id": schema.StringAttribute{


patrickcping · 2025-12-16T17:55:45Z

internal/service/davinci/data_source_davinci_connector_instances_gen.go

+		},
+		"GetConnectorInstances",
+		framework.DefaultCustomError,
+		framework.DefaultRetryable,


DefaultCreateReadRetryable

patrickcping · 2025-12-16T17:57:17Z

internal/service/davinci/data_source_davinci_connectors_gen.go

+				},
+				Computed: true,
+			},
+			"environment_id": schema.StringAttribute{


We have framework.Attr_LinkID for consistency

patrickcping · 2025-12-16T17:57:32Z

internal/service/davinci/data_source_davinci_connectors_gen.go

+					stringvalidator.RegexMatches(regexp.MustCompile("^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$"), "Must be a valid UUID"),
+				},
+			},
+			"id": schema.StringAttribute{


We have framework.Attr_ID for consistency

patrickcping · 2025-12-16T17:57:59Z

internal/service/davinci/data_source_davinci_connectors_gen.go

+		},
+		"GetConnectors",
+		framework.DefaultCustomError,
+		framework.DefaultRetryable,


DefaultCreateReadRetryable

patrickcping · 2025-12-16T18:00:38Z

internal/service/davinci/data_source_davinci_connectors_gen.go

+
+		func() (any, *http.Response, error) {
+			fO, fR, fErr := r.Client.DaVinciConnectorsApi.GetConnectors(ctx, environmentIdUuid).Execute()
+			return framework.CheckEnvironmentExistsOnPermissionsError(ctx, r.Client, data.EnvironmentId.ValueString(), fO, fR, fErr)


I haven't pointed it out on any other reviews so far, but it occurs to me that the new SDK should now be fulfilling the role of framework.CheckEnvironmentExistsOnPermissionsError. Anything that exists on the new SDK could have this check removed (although it does not hurt to have it remain)

henryrecker-pingidentity and others added 22 commits August 5, 2025 09:57

Initial connector_instance data source

351a826

Final generated davinci_connector_instance

83bb862

Including filled-out test template

Initial davinci_connector_instances data source and test

6586e41

Fill out test

f72b1b4

Add DV application singular and plural data sources

db2d1e7

davinci connector singular and plural data sources

2349cbe

Create davinci bootstrapped test env

1eee5e0

Add bootstrap tests for connector_instance data source

3740a6e

Add bootstrap tests for connector_instances plural data source

eaa537b

Generate docs for connector data sources

e6b8d75

Add bootstrap tests for davinci_application singular data source

e76b662

Generate docs for application data sources

d410442

Rename attribute to align with resource

de444d0

spjwks_url should be sp_jwks_url

Add bootstrap test for davinci_applications plural data source

198d353

Format top-level descriptions

28dbd70

Add bootstrap tests for davinci_connectors data sources

4cb9434

Add example and docs for davinci_connector data sources

6899fed

Handle linter issues

20f5974

Merge branch 'DavinciApplicationKeyAndSecretResources' into DavinciDa…

3b5531a

…taSources

Merge branch 'DavinciApplicationKeyAndSecretResources' into DavinciDa…

79aa3a0

…taSources

Mark data sources as beta

f564d2a

Update client and fix test prechecks

6e4c00e

henryrecker-pingidentity requested a review from a team as a code owner December 1, 2025 22:01

patrickcping approved these changes Dec 16, 2025

View reviewed changes

Replace example.com with pingidentity.com in tests

d723ee6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

DaVinci beta data sources #1174

DaVinci beta data sources #1174

Uh oh!

henryrecker-pingidentity commented Dec 1, 2025

Uh oh!

patrickcping left a comment

Uh oh!

patrickcping Dec 16, 2025

Uh oh!

patrickcping Dec 16, 2025

Uh oh!

Uh oh!

patrickcping Dec 16, 2025

Uh oh!

patrickcping Dec 16, 2025

Uh oh!

patrickcping Dec 16, 2025

Uh oh!

patrickcping Dec 16, 2025

Uh oh!

patrickcping Dec 16, 2025

Uh oh!

patrickcping Dec 16, 2025

Uh oh!

patrickcping Dec 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

DaVinci beta data sources #1174

Are you sure you want to change the base?

DaVinci beta data sources #1174

Uh oh!

Conversation

henryrecker-pingidentity commented Dec 1, 2025

Change Description

Change Characteristics

Checklist

Required SDK Upgrades

Testing

Shell Command(s)

Testing Results

End-to-end Tests Workflow Links

Uh oh!

patrickcping left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants