pingone_davinci_flow beta resource #1175
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logic for writing to state untested and almost certainly doesn't work
Prevent unnecessary plans due to computed values and missing is_expanded handling
Allows for larger precision floats
Currently failing due to computed value with stopgap UseStateForUnknown in place
Will still need to add validators to child required attributes preferred_data_type and property_name. Had to add computed+optional to all children of input_schema.
Keeps test file size manageable
…e issue TRIAGE-29360
… attrs This allows us to effectively require the attribute while avoid unnecessary plans
…ated as literal "null"
…al null or literal "{}"
These retries account for permissions that have not propagated yet on the backend
Only pass in string on post/put, cast to string on response if necessary
This reverts commit 8491fce.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Add
pingone_davinci_flowbeta resourceChange Characteristics
Checklist
All full (or complete) PRs that need review prior to merge should have the following box checked.
If contributing a partial or incomplete change (expecting the development team to complete the remaining work) please leave the box unchecked
Required SDK Upgrades
Testing
This PR has been tested with:
Shell Command(s)
TF_ACC=1 TESTACC_BETA=true go test -tags=beta -v -timeout 300s -run ^TestAccDavinciFlow github.com/pingidentity/terraform-provider-pingone/internal/service/davinciTesting Results
Includes some access failed errors in post-test destroys, but the tests themselves pass
Expand Results
=== RUN TestAccDavinciFlow_RemovalDrift === PAUSE TestAccDavinciFlow_RemovalDrift === RUN TestAccDavinciFlow_MinimalMaximalClean === PAUSE TestAccDavinciFlow_MinimalMaximalClean === RUN TestAccDavinciFlow_MinimalMaximalWithBootstrap === PAUSE TestAccDavinciFlow_MinimalMaximalWithBootstrap === RUN TestAccDavinciFlow_BasicClean === PAUSE TestAccDavinciFlow_BasicClean === RUN TestAccDavinciFlow_BasicWithBootstrap === PAUSE TestAccDavinciFlow_BasicWithBootstrap === RUN TestAccDavinciFlow_EmptyObjectsInSettings === PAUSE TestAccDavinciFlow_EmptyObjectsInSettings === RUN TestAccDavinciFlow_ComplexObjectsInSettings === PAUSE TestAccDavinciFlow_ComplexObjectsInSettings === RUN TestAccDavinciFlow_VariableRefsClean === PAUSE TestAccDavinciFlow_VariableRefsClean === RUN TestAccDavinciFlow_VariableRefsWithBootstrap === PAUSE TestAccDavinciFlow_VariableRefsWithBootstrap === RUN TestAccDavinciFlow_NewEnv === PAUSE TestAccDavinciFlow_NewEnv === RUN TestAccDavinciFlow_BadParameters === PAUSE TestAccDavinciFlow_BadParameters === CONT TestAccDavinciFlow_RemovalDrift === CONT TestAccDavinciFlow_ComplexObjectsInSettings === CONT TestAccDavinciFlow_BasicClean === CONT TestAccDavinciFlow_EmptyObjectsInSettings === CONT TestAccDavinciFlow_BasicWithBootstrap === CONT TestAccDavinciFlow_NewEnv === CONT TestAccDavinciFlow_BadParameters === CONT TestAccDavinciFlow_MinimalMaximalClean === CONT TestAccDavinciFlow_VariableRefsWithBootstrap === CONT TestAccDavinciFlow_VariableRefsClean === CONT TestAccDavinciFlow_MinimalMaximalWithBootstrap --- PASS: TestAccDavinciFlow_EmptyObjectsInSettings (23.19s) === NAME TestAccDavinciFlow_BadParameters resource_davinci_flow_gen_test.go:394: Error running post-test destroy, there may be dangling resources: ACCESS_FAILED --- FAIL: TestAccDavinciFlow_BadParameters (23.49s) --- PASS: TestAccDavinciFlow_ComplexObjectsInSettings (23.66s) --- PASS: TestAccDavinciFlow_NewEnv (47.39s) --- PASS: TestAccDavinciFlow_RemovalDrift (92.40s) --- PASS: TestAccDavinciFlow_VariableRefsClean (93.27s) === NAME TestAccDavinciFlow_VariableRefsWithBootstrap resource_davinci_flow_gen_test.go:334: Error running post-test destroy, there may be dangling resources: ACCESS_FAILED --- FAIL: TestAccDavinciFlow_VariableRefsWithBootstrap (97.95s) === NAME TestAccDavinciFlow_BasicWithBootstrap resource_davinci_flow_gen_test.go:206: Error running post-test destroy, there may be dangling resources: ACCESS_FAILED --- FAIL: TestAccDavinciFlow_BasicWithBootstrap (127.93s) === NAME TestAccDavinciFlow_BasicClean resource_davinci_flow_gen_test.go:206: Error running post-test destroy, there may be dangling resources: ACCESS_FAILED --- FAIL: TestAccDavinciFlow_BasicClean (130.02s) --- PASS: TestAccDavinciFlow_MinimalMaximalClean (215.91s) === NAME TestAccDavinciFlow_MinimalMaximalWithBootstrap resource_davinci_flow_gen_test.go:95: Error running post-test destroy, there may be dangling resources: ACCESS_FAILED --- FAIL: TestAccDavinciFlow_MinimalMaximalWithBootstrap (226.32s) FAIL FAIL github.com/pingidentity/terraform-provider-pingone/internal/service/davinci 226.853s FAILEnd-to-end Tests Workflow Links