pingone_davinci_flow_deploy and pingone_davinci_flow_enabled beta resources #1177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lse (#1180) * Implement workaround for boolean false values * Test creation from scratch with false value * Relax validation to support importing variables created via UI Allow string field to be used for all types except secret_string
patrickcping
approved these changes
Dec 16, 2025
Collaborator
patrickcping
left a comment
patrickcping
left a comment
There was a problem hiding this comment.
A few things to look at but once they're addressed, LGTM 🚀 🚀
| resp.Schema = schema.Schema{ | ||
| Description: "Resource to deploy a DaVinci flow.", | ||
| Attributes: map[string]schema.Attribute{ | ||
| "environment_id": schema.StringAttribute{ |
Collaborator
There was a problem hiding this comment.
There is framework.Attr_LinkID for consistency
| stringvalidator.RegexMatches(regexp.MustCompile("^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$"), "Must be a valid UUID"), | ||
| }, | ||
| }, | ||
| "flow_id": schema.StringAttribute{ |
Collaborator
There was a problem hiding this comment.
This may be better as the DV custom type.
| stringplanmodifier.RequiresReplace(), | ||
| }, | ||
| }, | ||
| "id": schema.StringAttribute{ |
Collaborator
There was a problem hiding this comment.
We have framework.Attr_ID for consistency
| }, | ||
| "DeployFlow", | ||
| framework.DefaultCustomError, | ||
| framework.InsufficientPrivilegeRetryable, |
Collaborator
There was a problem hiding this comment.
Assuming this is new to the base branch of the PR, this should already be implemented as DefaultCreateReadRetryable
| }, | ||
| "GetFlowById", | ||
| framework.CustomErrorResourceNotFoundWarning, | ||
| framework.InsufficientPrivilegeRetryable, |
| }, | ||
| "GetFlowById", | ||
| framework.CustomErrorResourceNotFoundWarning, | ||
| framework.InsufficientPrivilegeRetryable, |
Collaborator
There was a problem hiding this comment.
This is probably doing the same job as DefaultCreateReadRetryable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
pingone_davinci_flow_deployresourcepingone_davinci_flow_enabledresource to control enabling and disabling flowspingone_davinci_flowresourceChange Characteristics
Checklist
All full (or complete) PRs that need review prior to merge should have the following box checked.
If contributing a partial or incomplete change (expecting the development team to complete the remaining work) please leave the box unchecked
Required SDK Upgrades
Testing
This PR has been tested with:
Shell Command(s)
Testing Results
Currently the broken deploy tests are failing due to a client issue - will be fixed by pingidentity/pingone-go-client#54. I pasted the local run of the enabled tests below, and will rely on the end-to-end tests linked below for the deploy test results, since they can take a long time to run due to the retries.
Expand Results
End-to-end Tests Workflow Links