Avoid dropping packets for simulcast probes #2777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2777 +/- ##
==========================================
+ Coverage 83.99% 84.05% +0.06%
==========================================
Files 80 80
Lines 9070 9076 +6
==========================================
+ Hits 7618 7629 +11
+ Misses 1027 1024 -3
+ Partials 425 423 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Contributor
Author
Member
|
Is this still relevant? It looks like a thing that's worth fixing. |
Sean-Der
added a commit
to cptpcrd/srtp
that referenced
this pull request
Nov 28, 2025
This will be used while probing for PayloadType and Simulcast. Relates to pion/webrtc#2777 Co-authored-by: cptpcrd <[email protected]>
Sean-Der
added a commit
to cptpcrd/srtp
that referenced
this pull request
Nov 28, 2025
This will be used while probing for PayloadType and Simulcast. Relates to pion/webrtc#2777 Co-authored-by: cptpcrd <[email protected]>
Sean-Der
added a commit
to pion/srtp
that referenced
this pull request
Nov 28, 2025
This will be used while probing for PayloadType and Simulcast. Relates to pion/webrtc#2777 Co-authored-by: cptpcrd <[email protected]>
Sean-Der
force-pushed
the
fix-simulcast-probing
branch
2 times, most recently
from
68d8623 to
beba940
Compare
Sean-Der
force-pushed
the
fix-simulcast-probing
branch
2 times, most recently
from
e4e02a9 to
96a2e1a
Compare
Member
|
Sorry this took so long to get merged. With the holidays I hope to have more time to get through backlog. Super impressed that you diagnosed and fixed this! |
Sean-Der
force-pushed
the
fix-simulcast-probing
branch
2 times, most recently
from
bfd17cb to
1f7fa14
Compare
Sean-Der
reviewed
Nov 29, 2025
|
|
||
| return n, attributes, err | ||
| } | ||
| if receiver.haveClosed() { |
Member
There was a problem hiding this comment.
Before calling Read would return peaked packets (even though the Transceiver) was closed.
Sean-Der
approved these changes
Nov 29, 2025
Member
boks1971
approved these changes
Nov 29, 2025
peerconnection_media_test.go
Outdated
| } | ||
|
|
||
| // Simulcast probe would lose packets. This test asserts that we don't drop | ||
| // any packets during the probe. |
Contributor
There was a problem hiding this comment.
maybe remove comment which says Simulcast probe would lose packets. This PR fixes it. So, would be good to just say that this test ensures no drops during probe.
Before any packets that we read during the probe would get lost Co-authored-by: cptpcrd <[email protected]>
Sean-Der
force-pushed
the
fix-simulcast-probing
branch
from
1f7fa14 to
f71415b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when Pion is receiving simulcast,
PeerConnection.handleIncomingSSRCreads (at least) 2 packets: one packet is used to determine the payload type, and one (or more) packets are used to determine the MID, RID, and repair stream ID. This means that the first video frame is always partially lost, which is undesirable.To fix this:
(This patch relies on corresponding changes to
pion/srtpwhich I will PR shortly and link back here.)Reference issue
N/A