Updating to v1.1.0: fixes and new deserialize helper signature #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markbackman
approved these changes
Oct 28, 2025
mattieruth
reviewed
Dec 16, 2025
| val text: String, | ||
| val spoken: Boolean, | ||
| @SerialName("aggregated_by") | ||
| val aggregatedBy: String? = null |
There was a problem hiding this comment.
blech. You just pointed out an issue in client-web -- aggregatedBy really isn't optional. It should always be there. I think I wrote out the types in the client long before I finished all the server-side work and overlooked the ? when I went back to it.
mattieruth
approved these changes
Dec 16, 2025
mattieruth
left a comment
mattieruth
left a comment
There was a problem hiding this comment.
looks good. I won't block you, but two things:
- the aggregated_by not being optional
- any way to mark the
bot-transcriptionbits deprecated?
Contributor
Author
|
Thanks @mattieruth, I've addressed both comments, will merge shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.