Fix Missing French Localization#24
Closed
maxime-killinger wants to merge 5 commits intopiscoTech:masterfrom
Closed
Fix Missing French Localization#24maxime-killinger wants to merge 5 commits intopiscoTech:masterfrom
maxime-killinger wants to merge 5 commits intopiscoTech:masterfrom
Conversation
Fix for #23
maxime-killinger
changed the title
piscoTech
requested changes
Nov 24, 2020
Owner
piscoTech
left a comment
piscoTech
left a comment
There was a problem hiding this comment.
Looks good, thank you.
Besides the minor tweaks, can you rebase on top of master to simplify the merge?
Co-authored-by: Marco Boschi <boschi95@gmail.com>
Co-authored-by: Marco Boschi <boschi95@gmail.com>
Contributor
Author
|
Sorry for the delays, I've been really busy this past year |
piscoTech
approved these changes
Jan 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #23