fix: error when trying to pull exechealthz image for health and readiness probes #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ATGardner
force-pushed
the
remove-exechealthz-sidecar
branch
2 times, most recently
from
d8ecc70 to
e17d359
Compare
ATGardner
force-pushed
the
remove-exechealthz-sidecar
branch
from
e17d359 to
aa7d4f5
Compare
Eliminate the healthz container from the deployment and replace the HTTP checks in the liveness and readiness probes with exec commands using nslookup for better reliability in health checks.
ATGardner
force-pushed
the
remove-exechealthz-sidecar
branch
from
aa7d4f5 to
6c46702
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #20
i removed the health sidecar, and changed the default health and readiness probe values to use
exec.maybe they should just be hard-coded in the
deployment.yaml?