Skip to content

Conversation

@ddelnano
Copy link
Member

@ddelnano ddelnano commented Nov 18, 2024

Summary: Upgrade grafana plugin sdk to latest version

It's been a while since we've upgraded our core dependencies. Since I was already making a few changes here, I wanted to upgrade the plugin sdk to a recent version. I testing a variety of things, but please let me know if there is anything else I should verify in addition to my testing done.

Testing done: Built plugin and configured a data source with a local Grafana and tested the following:

  • Ran a variety of PxL script queries
  • Created dashboards from the scripts I ran
  • Used various query inspector settings to try and trigger more plugin behavior

@ddelnano ddelnano marked this pull request as draft November 18, 2024 23:34
@ddelnano ddelnano marked this pull request as ready for review February 10, 2025 22:10
@ddelnano ddelnano marked this pull request as draft February 10, 2025 22:11
@ddelnano ddelnano force-pushed the ddelnano/upgrade-grafana-plugin-sdk branch from 40a39cc to 2e0aa81 Compare February 10, 2025 23:23
ddelnano pushed a commit to ddelnano/grafana-plugin that referenced this pull request Nov 6, 2025
This commit fixes the build failures in PR pixie-io#104 by:

1. Adding root-level .eslintrc that extends from .config/.eslintrc
   - ESLint was unable to find configuration without this file

2. Installing missing webpack-related dependencies:
   - webpack v5 and webpack-cli (upgraded from webpack v4)
   - webpack plugins: copy-webpack-plugin, eslint-webpack-plugin,
     webpack-subresource-integrity, webpack-livereload-plugin,
     webpack-virtual-modules, fork-ts-checker-webpack-plugin
   - webpack loaders: imports-loader, sass-loader, sass, css-loader,
     style-loader, swc-loader
   - Other build tools: glob v10, tslib, @swc/helpers

3. Installing eslint-plugin-deprecation v2.0.0
   - Required by the new .config/.eslintrc configuration
   - Version 2.0.0 is compatible with ESLint 7.x

4. Updating .config/webpack/tsconfig.webpack.json:
   - Added skipLibCheck: true to skip type checking on declaration files
   - Added noImplicitAny: false to allow implicit any types

5. Updating package.json scripts:
   - Added TS_NODE_PROJECT environment variable to build and dev scripts
   - This ensures webpack-cli can properly load the TypeScript config

All CI checks now pass:
- yarn typecheck ✓
- yarn lint ✓
- yarn test:ci ✓
- yarn build ✓
- compatibility check ✓
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant