Repository navigation
test(scheduler): make lock-migration race deterministic - #115
Merged
Merged
Conversation
T1 always dispatches; T2 either starts before T1 migrates its pending lock or is correctly skipped on the real-session lock. Poll for that outcome instead of relying on 20/50ms Windows timing, and accept the busy-skip path while still rejecting a silently missing T2.
Lumea-art
force-pushed
the
test/scheduler-lock-race
branch
from
November 15, 2026 01:34
7661da0 to
6c28836
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits the unrelated Windows CI flake fix out of #112 as requested in review.\n\n est/scheduler/engine.test.ts assumed both T1 and T2 were always dispatched. On slower Windows runners T1 can migrate its pending lock to the real session before T2 starts; T2 is then correctly recorded as a busy skip under the skip policy. The test now polls for settlement and accepts either dispatch or busy-skip, while still requiring T1 to dispatch and T2 to not silently disappear.\n\nVerified with �itest run test/scheduler/engine.test.ts (34 passed).