Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add curl and jq for vttablet-preStop.sh #3

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Add curl and jq for vttablet-preStop.sh #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,10 @@ RUN rm -f /mysqld_exporter/mysqld_exporter
RUN CGO_ENABLED=0 GOOS="$TARGETOS" GOARCH="$TARGETARCH" make -C /mysqld_exporter build

FROM golang:alpine
RUN apk --no-cache add curl
RUN apk --no-cache add jq
COPY --from=build /mysqld_exporter/mysqld_exporter /bin/mysqld_exporter
EXPOSE 9104
USER nobody
WORKDIR /
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this required for anything or just a nice to have?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. It's a non-functional change I had teed up in my work tree in case I ever needed a dummy change to force the CI through another loop. I actually like it being in because otherwise the working directory is /go which is harmless but kind of nonsense.

ENTRYPOINT ["/bin/mysqld_exporter"]