Fix streaming behavior with sessions #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix is mirrored to match our internal fix within edge. See: planetscale/edge-gateway#1615 That internal fix includes more extensive tests and better explanation of the issue, applying the change here is trivial and is the exact same.
mdlayher
approved these changes
Jan 17, 2025
mattrobenolt
added a commit
to planetscale/cli
that referenced
this pull request
Jan 17, 2025
Brings in planetscale/psdbproxy#27 This is currently an unexercised path, so in practice this doesn't crash currently, but would trigger a crash once we enable this path on vtgates if using OLAP mode through `pscale connect` only.
mattrobenolt
added a commit
to planetscale/cli
that referenced
this pull request
Jan 17, 2025
Brings in planetscale/psdbproxy#27 This is currently an unexercised path, so in practice this doesn't crash currently, but would trigger a crash once we enable this path on vtgates if using OLAP mode through `pscale connect` only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is mirrored to match our internal fix within edge.
See: https://github.com/planetscale/edge-gateway/pull/1615
That internal fix includes more extensive tests and better explanation of the issue, applying the change here is trivial and is the exact same.