default to empty list

planetscale · Jan 31, 2025 · 0d623a1 · 0d623a1
1 parent 6fc44af
commit 0d623a1
Showing 1 changed file with 15 additions and 3 deletions.
diff --git a/internal/provider/password_resource.go b/internal/provider/password_resource.go
@@ -8,6 +8,7 @@ import (
 	"fmt"
 	"strings"
 
+	"github.com/hashicorp/terraform-plugin-framework/attr"
 	"github.com/hashicorp/terraform-plugin-framework/diag"
 	"github.com/hashicorp/terraform-plugin-framework/path"
 	"github.com/hashicorp/terraform-plugin-framework/resource"
@@ -71,6 +72,12 @@ func passwordResourceFromClient(ctx context.Context, password *planetscale.Passw
 	diags.Append(diags...)
 	region, diags := types.ObjectValueFrom(ctx, regionResourceAttrTypes, password.Region)
 	diags.Append(diags...)
+
+	cidrs := types.ListValueMust(types.StringType, []attr.Value{})
+	if password.Cidrs != nil {
+		cidrs = stringsToListValue(password.Cidrs, diags)
+	}
+
 	return &passwordResourceModel{
 		Organization: organization,
 		Database:     database,
@@ -89,7 +96,7 @@ func passwordResourceFromClient(ctx context.Context, password *planetscale.Passw
 		Role:           types.StringValue(password.Role),
 		TtlSeconds:     types.Float64Value(password.TtlSeconds),
 		Username:       types.StringPointerValue(password.Username),
-		Cidrs:          stringsToListValue(password.Cidrs, diags),
+		Cidrs:          cidrs,
 		PlainText:      plainText,
 
 		// manually removed from spec because currently buggy
@@ -107,6 +114,12 @@ func passwordWithPlaintextResourceFromClient(ctx context.Context, password *plan
 	diags.Append(diags...)
 	region, diags := types.ObjectValueFrom(ctx, regionResourceAttrTypes, password.Region)
 	diags.Append(diags...)
+
+	cidrs := types.ListValueMust(types.StringType, []attr.Value{})
+	if password.Cidrs != nil {
+		cidrs = stringsToListValue(password.Cidrs, diags)
+	}
+
 	return &passwordResourceModel{
 		Organization: organization,
 		Database:     database,
@@ -125,7 +138,7 @@ func passwordWithPlaintextResourceFromClient(ctx context.Context, password *plan
 		Role:           types.StringValue(password.Role),
 		TtlSeconds:     types.Float64Value(password.TtlSeconds),
 		Username:       types.StringPointerValue(password.Username),
-		Cidrs:          stringsToListValue(password.Cidrs, diags),
+		Cidrs:          cidrs,
 		PlainText:      types.StringValue(password.PlainText),
 
 		// manually removed from spec because currently buggy
@@ -188,7 +201,6 @@ func (r *passwordResource) Schema(ctx context.Context, req resource.SchemaReques
 			"cidrs": schema.ListAttribute{
 				Description: "List of IP addresses or CIDR ranges that can use this password.",
 				Optional:    true,
-				Computed:    false,
 				ElementType: types.StringType,
 			},