Add neuron profiling support to Scalene GUI and profiler#935
Merged
emeryberger merged 8 commits intoAug 18, 2025
Conversation
Contributor
nehamur
commented
Aug 18, 2025
nehamur
commented
- Enhanced GUI elements for neuron profiling visualization
- Updated profiler to support neuron-specific metrics
- Modified bundle for neuron profiling features
- Changed handling on Neuron-Monitor to avoid trainium device becoming overloaded
emeryberger
requested changes
Aug 18, 2025
- Restored stringLines function for proper multi-line comment formatting - Removed backup files and generated files from repo - Added node_modules to .gitignore - Enhanced GUI elements for neuron profiling visualization - Updated profiler to support neuron-specific metrics (NRT, NC) - Added neuron monitoring capabilities
nehamur
force-pushed
the
feature/NeuronPyProfiler
branch
from
701b877 to
8e8f78f
Compare
added 6 commits
August 18, 2025 13:21
…h profileLine - stringLines function now called to compute docstring lines for each file - makeProfileLine updated to accept is_docstring parameter - Docstring information properly passed through for multi-line comment formatting - Addresses maintainer feedback about function being inoperable
- Rebuilt bundle includes stringLines function integration - GUI now properly formats multi-line docstrings and comments - Bundle size: 37.2 KiB (includes neuron profiling + stringLines fixes)
…mpatibility - Changed lxml==5.1.0 to lxml>=5.1.0 to allow pip to install newer versions - Fixes build failures on Python 3.13 where lxml 5.1.0 lacks pre-built wheels - Avoids need to build lxml from source which requires system dependencies
emeryberger
requested changes
Aug 18, 2025
- Add hasNeuronData detection to only show neuron columns when data exists - Fixed makeTableHeader() and makeProfileLine() to accept hasNeuronData parameter - Neuron columns (NRT %, NC time) appear automatically when profile contains neuron data - Maintains stringLines functionality for docstring CSS styling - Updated webpack bundle with conditional neuron column logic - Prevents JavaScript errors from undefined neuron fields - Smoketest passes successfully
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.