-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the environment service to its own TLJH plugin #143
Conversation
@jtpio just to be sure, the |
Do you know if it's possible to move issues from a repo to another? I'm thinking to those ones: |
So the PlasmaBio would depend on both
Yes indeed, this can be done when this PR is complete using the Transfer issue button on the issue page: |
Perfect!
Good. And I guess the whole discussion is also transferred. |
Yes and there is even some status message that indicates that the issue was moved. |
tljh-config set limits.memory 2G | ||
tljh-config set limits.cpu 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can now set the default limits using tljh-config
, which is better than having them hardcoded in the Python code of the plugin.
The tljh-repo2docker
plugin is then able to pick them up to display the defaults in the UI: https://github.com/plasmabio/tljh-repo2docker/blob/ec9e2dee20095b11b4a933915694178775d50611/tljh_repo2docker/__init__.py#L80-L84
Tested on a fresh VM and the combination of the 2 plugins seems to be working as expected. We can consider moving some of the documentation to the |
Fixes #136.
Move the building of the Docker images to its own TLJH plugin, so it's easier to reuse in other TLJH deployments that don't use the same defaults as PlasmaBio.
The plugin is available at: https://github.com/plasmabio/tljh-repo2docker
tljh-repo2docker
to the plugin dependencies