Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the environment service to its own TLJH plugin #143

Merged
merged 5 commits into from
Apr 29, 2020

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Apr 28, 2020

Fixes #136.

Move the building of the Docker images to its own TLJH plugin, so it's easier to reuse in other TLJH deployments that don't use the same defaults as PlasmaBio.

The plugin is available at: https://github.com/plasmabio/tljh-repo2docker

  • Add tljh-repo2docker to the plugin dependencies
  • Update the documentation to mention the plugin

@pierrepo
Copy link
Contributor

@jtpio just to be sure, the tljh-plasmabio local plugins becomes tljh-repo2docker?

@pierrepo
Copy link
Contributor

Do you know if it's possible to move issues from a repo to another?

I'm thinking to those ones:

@jtpio
Copy link
Member Author

jtpio commented Apr 29, 2020

just to be sure, the tljh-plasmabio local plugins becomes tljh-repo2docker

tljh-plamasbio will still exist, but will be more about setting the JupyterHub config such as the PAMAuthenticator and using system users. And will also be much smaller in scope.

So the PlasmaBio would depend on both tljh-repo2docker and tljh-plasmabio.

Do you know if it's possible to move issues from a repo to another?

Yes indeed, this can be done when this PR is complete using the Transfer issue button on the issue page:

image

@pierrepo
Copy link
Contributor

So the PlasmaBio would depend on both tljh-repo2docker and tljh-plasmabio.

Perfect!

when this PR is complete using the Transfer issue button

Good. And I guess the whole discussion is also transferred.

@jtpio
Copy link
Member Author

jtpio commented Apr 29, 2020

And I guess the whole discussion is also transferred.

Yes and there is even some status message that indicates that the issue was moved.

@jtpio jtpio marked this pull request as ready for review April 29, 2020 14:07
Comment on lines +43 to +44
tljh-config set limits.memory 2G
tljh-config set limits.cpu 2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can now set the default limits using tljh-config, which is better than having them hardcoded in the Python code of the plugin.

The tljh-repo2docker plugin is then able to pick them up to display the defaults in the UI: https://github.com/plasmabio/tljh-repo2docker/blob/ec9e2dee20095b11b4a933915694178775d50611/tljh_repo2docker/__init__.py#L80-L84

@jtpio
Copy link
Member Author

jtpio commented Apr 29, 2020

Tested on a fresh VM and the combination of the 2 plugins seems to be working as expected.

We can consider moving some of the documentation to the tljh-repo2docker repo in a separate change, as mentioned in: plasmabio/tljh-repo2docker#4

@jtpio jtpio merged commit 4fcb2bf into plasmabio:master Apr 29, 2020
@jtpio jtpio deleted the tljh-docker-plugin branch April 29, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move the TLJH docker plugin to its own repo
2 participants