Reapply: real-time message writes to Honcho (re-land #42)#54
Draft
ajspig wants to merge 1 commit into
Draft
Conversation
This reverts commit b8156bd.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-applies the changes from #42, which were reverted in #53.
#42 made user prompts write to Honcho in real time on
UserPromptSubmit(instead of queuing for theSessionEndflush), and removed the local~/.honcho/message-queue.jsonlqueue. That was reverted in #53 because the real-time path is still blocked on something on the Honcho side.This PR holds those changes so we can re-land them the moment that's unblocked — do not merge until the Honcho-side blocker is resolved.
Merge order
revert-42-realtime-writesbranch; once Revert "Simplifying Adding Messages to Honcho (#42)" #53 merges and that branch is deleted, GitHub will auto-retarget this PR's base tomain.Contents
cache.ts— removes thequeueMessage()/ queue-file logicuser-prompt.ts— writes prompts to Honcho in real time (version-nag from feat: nag users when the honcho plugin is behind the published version #48 preserved)session-end.ts,config.ts— drop the queue-flush pathbunx tsc --noEmitpasses clean.🤖 Generated with Claude Code