Update acquisition channel UDF to prioritize display over paid search

priv/data_migrations/AcquisitionChannel/sql/acquisition_channel_functions.sql.eex

@@ -207,11 +207,11 @@ CREATE OR REPLACE FUNCTION acquisition_channel_lowered <%= @on_cluster_statement
 (referrer_source, utm_medium, utm_campaign, utm_source, click_id_param) ->
     multiIf(
         acquisition_channel_cross_network(utm_campaign), 'Cross-network',
+        acquisition_channel_display(utm_medium), 'Display',
         acquisition_channel_paid_shopping(referrer_source, utm_medium, utm_campaign), 'Paid Shopping',
         acquisition_channel_paid_search(referrer_source, utm_medium, utm_source, click_id_param), 'Paid Search',
         acquisition_channel_paid_social(referrer_source, utm_medium, utm_source), 'Paid Social',
         acquisition_channel_paid_video(referrer_source, utm_medium, utm_source), 'Paid Video',
-        acquisition_channel_display(utm_medium), 'Display',
         acquisition_channel_paid_medium(utm_medium), 'Paid Other',
         acquisition_channel_organic_shopping(referrer_source, utm_campaign), 'Organic Shopping',
         acquisition_channel_organic_social(referrer_source, utm_medium), 'Organic Social',

priv/ingest_repo/migrations/20241113194422_update_acquisition_channel_udf.exs

@@ -0,0 +1,7 @@
+defmodule Plausible.IngestRepo.Migrations.UpdateAcquisitionChannelUdf do
+  use Ecto.Migration
+
+  def change do
+    Plausible.DataMigration.AcquisitionChannel.run()
+  end
+end

test/plausible_web/controllers/api/external_controller_test.exs

@@ -1554,6 +1554,24 @@ defmodule PlausibleWeb.Api.ExternalControllerTest do
       assert session.acquisition_channel == "Display"
     end
 
+    test "display channel with gclid", %{conn: conn, site: site} do
+      params = %{
+        name: "pageview",
+        url: "http://example.com?utm_medium=display&utm_source=google&gclid=123identifier",
+        domain: site.domain
+      }
+
+      conn =
+        conn
+        |> put_req_header("user-agent", @user_agent)
+        |> post("/api/event", params)
+
+      session = get_created_session(site)
+
+      assert response(conn, 202) == "ok"
+      assert session.acquisition_channel == "Display"
+    end
+
     test "parses paid other channel", %{conn: conn, site: site} do
       params = %{
         name: "pageview",