Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easier to override render pass used by the CameraFrame #7321

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Easier to override render pass used by the CameraFrame #7321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
968880b
Easier to override render pass used by the CameraFrame
Jan 31, 2025
ce95d1d
simpler
Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/extras/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ export { RenderPassDof } from './render-passes/render-pass-dof.js';
export { RenderPassDownsample } from './render-passes/render-pass-downsample.js';
export { RenderPassUpsample } from './render-passes/render-pass-upsample.js';
export { RenderPassBloom } from './render-passes/render-pass-bloom.js';
export { RenderPassPrepass } from './render-passes/render-pass-prepass.js';
export { RenderPassSsao } from './render-passes/render-pass-ssao.js';
export { RenderPassTAA } from './render-passes/render-pass-taa.js';
export { CameraFrame } from './render-passes/camera-frame.js';
Expand Down
15 changes: 12 additions & 3 deletions src/extras/render-passes/camera-frame.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,9 +319,8 @@ class CameraFrame {
enable() {
Debug.assert(!this.renderPassCamera);

const cameraComponent = this.cameraComponent;
this.renderPassCamera = new RenderPassCameraFrame(this.app, cameraComponent, this.options);
cameraComponent.renderPasses = [this.renderPassCamera];
this.renderPassCamera = this.createRenderPass();
this.cameraComponent.renderPasses = [this.renderPassCamera];
}

disable() {
Expand All @@ -342,6 +341,16 @@ class CameraFrame {
this.renderPassCamera = null;
}

/**
* Creates a render pass for the camera frame. Override this method to utilize a custom render
* pass, typically one that extends {@link RenderPassCameraFrame}.
*
* @returns {RenderPassCameraFrame} - The render pass.
*/
createRenderPass() {
return new RenderPassCameraFrame(this.app, this.cameraComponent, this.options);
}

/**
* Sets the enabled state of the camera frame. Passing false will release associated resources.
*
Expand Down