Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Multiple changes and fixed related to the way UI system handles srgb #7335

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

mvaligursky
Copy link
Contributor

@mvaligursky mvaligursky commented Feb 6, 2025

  • CameraFrame no long overrides Camera's gammaCorrection and toneMapping settings, but uses those internally for forward passes only, controlled by toneMapping setting of the CameraFrame. This gives us separate control of tonmapping and gamma for the 3D scene, rendered by the CameraFrame, and separate controls for follow up rendering (UI).
  • few internal UI textures now correctly use SRGB format
  • few example UI textures are also correctly loaded as SRGB
  • new HDR example, which has both the 3d scene and UI texture element, and allows CameraFrame to be enabled/disabled and also control over tonemapping for the camera separately from tonemapping from CameraFrame.

Screenshot 2025-02-06 at 15 23 27

@mvaligursky mvaligursky merged commit da5c214 into main Feb 7, 2025
7 checks passed
@mvaligursky mvaligursky deleted the mv-ui-srgb branch February 7, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants