[2.9.x] Test with Java 21 instead of 11 #785
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Look at
These are more or less identical pull requests. However, if you look closer at #581 you will see it changed java 11 to 21.
Why this did not happen in #582 I don't know. So I guess 1) either it was forgotten to change it in #582 too or 2) it was a mistake to change it to 21 in #581.
Anyway, I think it's a good idea to just run against 17 and 21 and just drop 11 now (even though Play 3.0 and 2.9 still support 11). These are just example projects and some dependencies already require Java 17 (like flyway #780) - I think it's a good idea to show examples with latest dependencies even though they can not be used with Java 11.