Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.9.x] Test with Java 21 instead of 11 #785

Merged
merged 1 commit into from
Nov 17, 2024
Merged

Conversation

mkurz
Copy link
Member

@mkurz mkurz commented Nov 17, 2024

Look at

These are more or less identical pull requests. However, if you look closer at #581 you will see it changed java 11 to 21.
Why this did not happen in #582 I don't know. So I guess 1) either it was forgotten to change it in #582 too or 2) it was a mistake to change it to 21 in #581.

Anyway, I think it's a good idea to just run against 17 and 21 and just drop 11 now (even though Play 3.0 and 2.9 still support 11). These are just example projects and some dependencies already require Java 17 (like flyway #780) - I think it's a good idea to show examples with latest dependencies even though they can not be used with Java 11.

@mkurz mkurz merged commit 79a2699 into playframework:2.9.x Nov 17, 2024
34 checks passed
@mkurz mkurz deleted the java21 branch November 17, 2024 10:58
@ihostage
Copy link
Member

I just thought we should check an examples for minimal supported Java versions. 🤔
What do you think about check two version: minimal supported and latest LTS?
In 2.9.x case it will be 11 and 21.

@mkurz
Copy link
Member Author

mkurz commented Nov 17, 2024

We can do that as well of course, but then we need to pin some dependencies, like flyway, which in its latest version(s) requires Java 17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants