fix(cdp): handle missing timing fields in the response from CDP#581
Open
zikani03 wants to merge 1 commit intoplaywright-community:mainfrom
Open
fix(cdp): handle missing timing fields in the response from CDP#581zikani03 wants to merge 1 commit intoplaywright-community:mainfrom
zikani03 wants to merge 1 commit intoplaywright-community:mainfrom
Conversation
Signed-off-by: Zikani Nyirenda Mwase <zikani.nmwase@ymail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed handling of float values from the CDP timing response. To handle situation where an implementation of the CDP doesn't return appropriate timings or is missing some fields.
Go: 1.25
Playwright-go: v0.5200.1
Browser: Chromium-ish -> LightPanda via CDP
Reproduce
I was trying to use LightPanda's Browser which has support for CDP to use as an alternative to Chromium.
Follow the steps in order to reproduce.
Run the program
go run main.goObserve that there's a panic with the following in the error trace: