fixing branding test #31
Conversation
BMayhew
had a problem deploying
to
github-pages
GitHub Actions
Failure
BMayhew
had a problem deploying
to
github-pages
GitHub Actions
Failure
|
WalkthroughThe changes focus on enhancing branding functionality by updating the logo URL dynamically and adding an assertion for a response status code in a PUT request test. These modifications aim to improve the application's branding features and ensure proper handling of HTTP requests. Changes
Uplevel your code reviews with CodeRabbit ProCodeRabbit ProIf you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Files selected (2)
- lib/helpers/branding.ts (1)
- tests/branding/branding.spec.ts (1)
Review comments generated (5)
- Review: 5
- LGTM: 0
Tips
Chat with 
CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
| @@ -1,10 +1,12 @@ | |||
| import Env from "./env"; | |||
There was a problem hiding this comment.
Bruh, what's good with this import statement change? You swapped out the direct URL for a dynamic one from Env.URL. Make sure this change doesn't mess up the URL resolution logic. 🤔
| export const defaultBranding = { | ||
| name: "Shady Meadows B&B", | ||
| map: { | ||
| latitude: 52.6351204, | ||
| longitude: 1.2733774, | ||
| }, | ||
| logoUrl: "https://automationintesting.online/images/rbp-logo.jpg", | ||
| logoUrl: `${Env.URL}/images/room2.jpg`, |
There was a problem hiding this comment.
Yo, fam! The logoUrl change looks lit, but ensure that Env.URL resolves to the correct base URL. Keep an eye on this one! 🔍
| export const defaultBranding = { | ||
| name: "Shady Meadows B&B", | ||
| map: { | ||
| latitude: 52.6351204, | ||
| longitude: 1.2733774, | ||
| }, | ||
| logoUrl: "https://automationintesting.online/images/rbp-logo.jpg", | ||
| logoUrl: `${Env.URL}/images/room2.jpg`, | ||
| description: | ||
| "Welcome to Shady Meadows, a delightful Bed & Breakfast nestled in the hills on Newingtonfordburyshire. A place so beautiful you will never want to leave. All our rooms have comfortable beds and we provide breakfast from the locally sourced supermarket. It is a delightful place.", |
There was a problem hiding this comment.
This description block seems chill, no issues here. 🌟
| import Env from "./env"; | ||
|
|
||
| export const defaultBranding = { | ||
| name: "Shady Meadows B&B", | ||
| map: { | ||
| latitude: 52.6351204, | ||
| longitude: 1.2733774, | ||
| }, | ||
| logoUrl: "https://automationintesting.online/images/rbp-logo.jpg", | ||
| logoUrl: `${Env.URL}/images/room2.jpg`, | ||
| description: | ||
| "Welcome to Shady Meadows, a delightful Bed & Breakfast nestled in the hills on Newingtonfordburyshire. A place so beautiful you will never want to leave. All our rooms have comfortable beds and we provide breakfast from the locally sourced supermarket. It is a delightful place.", | ||
| contact: { |
There was a problem hiding this comment.
Note: This review was outside of the patch, but no patch was found that overlapped with it. Original lines [13-13]
No changes detected in this line range.
Keep it sharp, developer! Remember, details matter when it comes to code changes. Don't let those bugs sneak in like ninjas in the night! 💥🐰
| const response = await request.put("branding/", { | ||
| headers: headers, | ||
| data: defaultBody, | ||
| }); | ||
| expect(response.status()).toBe(202); |
There was a problem hiding this comment.
Bruh, we got a spicy issue here! 🌶️ Looks like you misspelled status as a function in expect(response.status()).toBe(202);. It should be expect(response.status).toBe(202);. Gotta keep those syntax errors in check, fam!
- expect(response.status()).toBe(202);
+ expect(response.status).toBe(202);
Summary by CodeRabbit
Remember, bugs are like ants in your code - they may be small, but they can cause a big picnic! 🐜🧺