Don't search for indices on classes without tables #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fightingtheboss
changed the title
Update the `LolDba::IndexFinding.model_classes` method to return only classes that have a table in the database.
|
Nice! I had some problems with action text too 👍 |
|
Any updates on if this can be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
LolDba::IndexFinderwas iterating over all subclasses ofActiveRecord::Base, including abstract classes that don't have backing tables in the DB (namely ActionText and ActionMailbox).This change simply omits classes without backing tables from the search for missing indices.
Resolves #146