Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test: plone.app.discussion #3002

Closed
wants to merge 12 commits into from
Closed

Conversation

ksuess
Copy link
Member

@ksuess ksuess commented Dec 10, 2019

plone.app.discussion introduces an additional workflow. This change takes the additional workflow states into account.
See plone/plone.app.discussion#164

thet and others added 8 commits October 26, 2019 18:10
Fix TTW Bundle compilation broken.
#2971)

* Fix #1318: Always install default content types on Plone site creation

* Update changelog entry
Apply types controlpanel fix to master.
…n reset (#2994)

* Test if events fired after auto login have the correct principal

* At this point the user is not logged in yet, so we get it from the membership_tool.

* Update changelog

* Remove adapter registration for IUserLoggedInEvent

* Fix unregistering of adapter

* Deal with cases where username/email were not the userid
@mister-roboto
Copy link

@ksuess thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

@ksuess
Copy link
Member Author

ksuess commented Jan 11, 2020

Obsolete.
plone/plone.app.discussion#166 extends the existing review workflow instead of adding an additional workflow.

@ksuess ksuess closed this Jan 11, 2020
@ksuess
Copy link
Member Author

ksuess commented Jan 13, 2020

Reopened pull request: tests need to take plone.app.discussion workflow stati into account, even for replaced pull request in plone.app.discussion plone/plone.app.discussion#166

@ksuess ksuess reopened this Jan 13, 2020
@mister-roboto
Copy link

@ksuess thanks for creating this Pull Request and help improve Plone!

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass.

Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating:

@jenkins-plone-org please run jobs

With this simple comment all the jobs will be started automatically.

Happy hacking!

plone.app.discussion introduces an additional workflow. This change takes the additional workflow states into account.
@ksuess ksuess force-pushed the plone.app.discussion-moderation branch from cdfa540 to 7af3319 Compare January 13, 2020 08:36
@ksuess ksuess closed this Mar 16, 2020
@ksuess ksuess deleted the plone.app.discussion-moderation branch March 16, 2020 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants