-
-
Notifications
You must be signed in to change notification settings - Fork 10
Removed the misleading -dev from the backend acceptance make command.
#323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
stevepiercy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor tweak to news.
CI checks are failing. Did you run tests locally? If not, check out this repo's readme for how to do so. See https://github.com/plone/cookieplone-templates?tab=readme-ov-file#run-tests. Then you can make sure things work and pass tests before pushing changes.
|
Co-authored-by: Steve Piercy <[email protected]>
|
@boss6825 for an extra challenge, would you please take a look @wesleybl's comment #323 (comment) and attempt to address the failing CI checks? We don't merge PRs that don't pass all CI checks and tests. Thank you! |
|
@stevepiercy The fix has already been made, but @sneridagh needs to generate a release of Volto. |
templates/projects/monorepo/{{ cookiecutter.__folder_name }}/Makefile
Outdated
Show resolved
Hide resolved
|
@davisagli I have made the required changes .... |
If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.
Closes #121