Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deprecation chapter #1850

Open
wants to merge 28 commits into
base: 6.0
Choose a base branch
from
Open

add deprecation chapter #1850

wants to merge 28 commits into from

Conversation

MrTango
Copy link
Contributor

@MrTango MrTango commented Feb 11, 2025

First-time contributors

You must read and follow our First-time contributors.


Submit a pull request

Thank you for your contribution to the Plone Documentation.

Before submitting this pull request, please make sure you follow our guides:

Issue number

  • Fixes #

Description

Write a description of the fixes or improvements.

Add screenshots or links to a preview of the changes


📚 Documentation preview 📚: https://plone6--1850.org.readthedocs.build/backend/deprecation.html

docs/backend/deprecation.md Outdated Show resolved Hide resolved
docs/backend/deprecation.md Outdated Show resolved Hide resolved
docs/backend/deprecation.md Show resolved Hide resolved
docs/backend/deprecation.md Outdated Show resolved Hide resolved
docs/backend/deprecation.md Outdated Show resolved Hide resolved
docs/backend/deprecation.md Outdated Show resolved Hide resolved
docs/backend/deprecation.md Show resolved Hide resolved
docs/backend/deprecation.md Outdated Show resolved Hide resolved
docs/backend/deprecation.md Outdated Show resolved Hide resolved
docs/backend/deprecation.md Outdated Show resolved Hide resolved
docs/backend/deprecation.md Outdated Show resolved Hide resolved
docs/backend/deprecation.md Outdated Show resolved Hide resolved
docs/backend/deprecation.md Outdated Show resolved Hide resolved
docs/backend/deprecation.md Outdated Show resolved Hide resolved
docs/backend/deprecation.md Outdated Show resolved Hide resolved
docs/backend/deprecation.md Outdated Show resolved Hide resolved
docs/backend/deprecation.md Outdated Show resolved Hide resolved
docs/backend/deprecation.md Outdated Show resolved Hide resolved
MrTango and others added 3 commits February 12, 2025 11:39
Copy link
Contributor

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the amended original plan #1464 (comment)

.gitignore Outdated Show resolved Hide resolved

: They may got renamed for consistency or are superfluos after an update.
Code does not need to break to support this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything up to this point is a Conceptual Guide, and needs to be split into a separate file placed in the conceptual-guides directory.

Everything after this point is a How-to Guide and should be moved under Developer guide. This section is a recent addition, and more suitable for this content.

Copy link
Member

@jensens jensens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall fine, found two minor improvements.

docs/backend/deprecation.md Outdated Show resolved Hide resolved
docs/backend/deprecation.md Outdated Show resolved Hide resolved
docs/backend/deprecation.md Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
docs/backend/deprecation.md Outdated Show resolved Hide resolved
@@ -22,6 +22,7 @@ behaviors
configuration-registry
content-types/index
control-panels
deprecation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you all think that this insertion point in the TOC is the most appropiate place for this subject?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not. See #1850 (review).

@jensens jensens self-requested a review February 17, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: in progress
Status: In Progress
Development

Successfully merging this pull request may close these issues.

5 participants