-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add deprecation chapter #1850
base: 6.0
Are you sure you want to change the base?
add deprecation chapter #1850
Conversation
Co-authored-by: Alessandro Pisa <[email protected]>
Co-authored-by: Alessandro Pisa <[email protected]>
Co-authored-by: Alessandro Pisa <[email protected]>
Co-authored-by: Alessandro Pisa <[email protected]>
Co-authored-by: Alessandro Pisa <[email protected]>
Co-authored-by: Alessandro Pisa <[email protected]>
Co-authored-by: Alessandro Pisa <[email protected]>
Co-authored-by: Alessandro Pisa <[email protected]>
Co-authored-by: Alessandro Pisa <[email protected]>
Co-authored-by: Alessandro Pisa <[email protected]>
Co-authored-by: Alessandro Pisa <[email protected]>
Co-authored-by: Alessandro Pisa <[email protected]>
Co-authored-by: Alessandro Pisa <[email protected]>
Co-authored-by: Alessandro Pisa <[email protected]>
Co-authored-by: Alessandro Pisa <[email protected]>
Co-authored-by: Alessandro Pisa <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the amended original plan #1464 (comment)
|
||
: They may got renamed for consistency or are superfluos after an update. | ||
Code does not need to break to support this. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything up to this point is a Conceptual Guide, and needs to be split into a separate file placed in the conceptual-guides
directory.
Everything after this point is a How-to Guide and should be moved under Developer guide. This section is a recent addition, and more suitable for this content.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall fine, found two minor improvements.
Co-authored-by: Alessandro Pisa <[email protected]> Co-authored-by: Jens W. Klein <[email protected]>
@@ -22,6 +22,7 @@ behaviors | |||
configuration-registry | |||
content-types/index | |||
control-panels | |||
deprecation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you all think that this insertion point in the TOC is the most appropiate place for this subject?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not. See #1850 (review).
First-time contributors
You must read and follow our First-time contributors.
Submit a pull request
Thank you for your contribution to the Plone Documentation.
Before submitting this pull request, please make sure you follow our guides:
Issue number
Description
Write a description of the fixes or improvements.
Add screenshots or links to a preview of the changes
📚 Documentation preview 📚: https://plone6--1850.org.readthedocs.build/backend/deprecation.html