Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the livehtml file watcher #1853

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Fix the livehtml file watcher #1853

merged 1 commit into from
Feb 12, 2025

Conversation

stevepiercy
Copy link
Contributor

@stevepiercy stevepiercy commented Feb 12, 2025

@sneridagh reported, and I verified during the Alpine Sprint, that when using make livehtml, any changes in the following symlinked paths...

volto
plone.api
plone.restapi

...would result in no changes detected, and therefore no live reload. This PR fixes that bug.

Note, this was working fine before, and even as recently as last week. There was a macOS update last week. It's unlikely to be related. Also if anyone recently set this up, it might not affect them.


📚 Documentation preview 📚: https://plone6--1853.org.readthedocs.build/

@stevepiercy stevepiercy self-assigned this Feb 12, 2025
Copy link
Member

@sneridagh sneridagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!

@stevepiercy stevepiercy merged commit 48dcdaa into 6.0 Feb 12, 2025
4 checks passed
@stevepiercy stevepiercy deleted the fix-make-livehtml-watcher branch February 12, 2025 09:29
sneridagh pushed a commit that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants