Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Volto submodule with fixed MDN links(updated the outdated links) #1862

Closed
wants to merge 2 commits into from

Conversation

GOGETASSB23
Copy link

@GOGETASSB23 GOGETASSB23 commented Feb 15, 2025

Description
This PR updates outdated MDN links in docs/source/blocks/block-style-wrapper.md. The previous links were either broken or redirected, which caused test failures in my earlier PR. Updating them ensures the documentation remains accurate and prevents validation errors.

Changes Made
Replaced outdated MDN links with the latest working versions.
Ensured all references correctly point to the relevant MDN documentation pages.
Issue Resolved
This update fixes the test errors caused by broken links in my previous PR.

Checklist
Updated documentation links
Verified that all links are accessible and correct
Ensured no broken references remain


📚 Documentation preview 📚: https://plone6--1862.org.readthedocs.build/

@GOGETASSB23
Copy link
Author

GOGETASSB23 commented Feb 15, 2025

@stevepiercy sir, if this PR gets merged, will my previous PR(adding a reference guide for cookieplone make commands) get merged as well?

@stevepiercy
Copy link
Contributor

This is wrong. Do not commit submodules. Additionally the files you modified need to have content that is useful for the reader to accomplish the how-to guide.

@GOGETASSB23
Copy link
Author

The submodules needed to be committed because the MDN links were insiide them(submodules/volto/docs/blocks/ ) , which were needed to be updated(beause they were outdated) , which caused test errors in my previous PRs .. Please let me know how to proceed, because each new PR is coming up with a new test error

@stevepiercy
Copy link
Contributor

I don't think you understand what is a git submodule. It is not the content within a directory named submodules.

See Contribute to documentation for how to proceed, especially Editing external package documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants