-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes #35
Various fixes #35
Commits on Sep 11, 2024
-
Fix error when importings translations.json and plone.app.multilingua…
…l is not installed. The distribution may have a `translations.json` with only an empty string. That should not break like this: ``` Traceback (innermost last): Module ZPublisher.WSGIPublisher, line 181, in transaction_pubevents Module ZPublisher.WSGIPublisher, line 391, in publish_module Module ZPublisher.WSGIPublisher, line 285, in publish Module ZPublisher.mapply, line 98, in mapply Module ZPublisher.WSGIPublisher, line 68, in call_object Module plone.rest.service, line 21, in __call__ Module plone.restapi.services, line 19, in render Module plone.distribution.services.sites.add, line 49, in reply Module plone.distribution.api.site, line 165, in create Module plone.distribution.api.site, line 104, in _create_site Module plone.distribution.handler, line 44, in default_handler Module plone.exportimport.importers, line 57, in import_site Module plone.exportimport.importers.base, line 70, in import_data Module plone.exportimport.importers.translations, line 17, in do_import TypeError: object of type 'NoneType' has no len() ```
Configuration menu - View commit details
-
Copy full SHA for ea13576 - Browse repository at this point
Copy the full SHA ea13576View commit details -
Register translations and discussions importers and exporters conditi…
…onally. Only register them when `plone.app.multilingual` and `plone.app.discussion` are installed. Prevent error when an exporter does not actually export any paths, but returns None, like before I made these two conditional: ``` $ bin/export-distribution parts/zeoclient-classic/etc/zope.conf Plone Exporting Plone site at /Plone Target path: /Users/maurits/community/plone-coredev/6.1/src/plone.classicui/src/plone/classicui/distributions/classic/content Traceback (most recent call last): File "/Users/maurits/community/plone-coredev/6.1/bin/export-distribution", line 250, in <module> sys.exit(plone.distribution.cli.export()) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/maurits/community/plone-coredev/6.1/src/plone.distribution/src/plone/distribution/cli/__init__.py", line 44, in export results = get_exporter(site).export_site(path) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/maurits/community/plone-coredev/6.1/src/plone.exportimport/src/plone/exportimport/exporters/__init__.py", line 72, in export_site paths.extend(exporter.export_data(path)) TypeError: 'NoneType' object is not iterable ```
Configuration menu - View commit details
-
Copy full SHA for 93da922 - Browse repository at this point
Copy the full SHA 93da922View commit details -
Set it to neutral None, unless it is explicitly set.
Configuration menu - View commit details
-
Copy full SHA for acb72cf - Browse repository at this point
Copy the full SHA acb72cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8916588 - Browse repository at this point
Copy the full SHA 8916588View commit details -
Export: add newline at end of all files.
`json.dump` does not add this, so we explicitly do it. Otherwise when you manually edit a file and you use an editor that respects the standard `.editorconfig` that we have in most Plone packages, you always get a diff because there is a newline at the end.
Configuration menu - View commit details
-
Copy full SHA for 9d5996c - Browse repository at this point
Copy the full SHA 9d5996cView commit details -
We now have some data with a blacklist_status, and this gave an error.
Configuration menu - View commit details
-
Copy full SHA for f804610 - Browse repository at this point
Copy the full SHA f804610View commit details
Commits on Sep 12, 2024
-
Portlets: deprecate blacklist_status in favor of disallowlist_status.
We still read the old key for backwards compatibility.
Configuration menu - View commit details
-
Copy full SHA for 441f6c1 - Browse repository at this point
Copy the full SHA 441f6c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 11e2bab - Browse repository at this point
Copy the full SHA 11e2babView commit details -
Configuration menu - View commit details
-
Copy full SHA for b07483c - Browse repository at this point
Copy the full SHA b07483cView commit details -
Configuration menu - View commit details
-
Copy full SHA for cbeeb9b - Browse repository at this point
Copy the full SHA cbeeb9bView commit details