Skip to content

Commit

Permalink
added loader for order tab
Browse files Browse the repository at this point in the history
  • Loading branch information
Abhishek-17h committed Jan 19, 2025
1 parent 7b06c00 commit 18400c6
Show file tree
Hide file tree
Showing 4 changed files with 51 additions and 6 deletions.
2 changes: 1 addition & 1 deletion packages/volto/news/6492.bugfix
Original file line number Diff line number Diff line change
@@ -1 +1 @@
You can now render the order side panel only when the 'Order' tab is active. Previously, the panel would render unnecessarily even when not active.@Abhishek-17h
The Order side panel now renders only when the "Order" tab is active. Previously, the panel would render unnecessarily even when inactive. @Abhishek-17h
7 changes: 2 additions & 5 deletions packages/volto/src/components/manage/Sidebar/Sidebar.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import BodyClass from '@plone/volto/helpers/BodyClass/BodyClass';
import { getCookieOptions } from '@plone/volto/helpers/Cookies/cookies';
import Icon from '@plone/volto/components/theme/Icon/Icon';
import forbiddenSVG from '@plone/volto/icons/forbidden.svg';
import loaderSVG from '@plone/volto/icons/loader.svg';
import { setSidebarTab } from '@plone/volto/actions/sidebar/sidebar';
import expandSVG from '@plone/volto/icons/left-key.svg';
import collapseSVG from '@plone/volto/icons/right-key.svg';
Expand Down Expand Up @@ -193,11 +194,7 @@ const Sidebar = (props) => {
className="tab-wrapper"
id="sidebar-order"
>
<Icon
className="tab-forbidden"
name={forbiddenSVG}
size="48px"
/>
<Icon className="tab-loader" name={loaderSVG} size="60px" />
</Tab.Pane>
) : null,
},
Expand Down
43 changes: 43 additions & 0 deletions packages/volto/src/icons/loader.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
5 changes: 5 additions & 0 deletions packages/volto/theme/themes/pastanaga/extras/sidebar.less
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,11 @@
color: #bac5c7;
}

.tab-loader {
margin: calc(50% - 24px) auto;
color: #bac5c7;
}

header {
display: flex;
height: 60px;
Expand Down

0 comments on commit 18400c6

Please sign in to comment.