Refactored Edit component from class based to function based #6187
Conversation
✅ Deploy Preview for plone-components canceled.
|
|
@shiven16 please read and follow Change log entry and Linting. |
|
@shiven16 please check Change log entry and Linting again, and now check why the acceptance tests fail by comparing the GitHub workflow result against your local acceptance test run, as described in Acceptance tests. It might also be helpful for you to review the entire Developer guidelines, so that I don't have to keep pointing you to each thing that does not pass CI. |
I apologize for any inconvenience caused. I will ensure that all tests are run locally prior to committing changes to the repository. |
|
@shiven16 please read and follow Code quality. You should run all of these checks locally to ensure they pass before creating a pull request. Then you can compare your results against the GitHub workflows. See also Update your pull request from your fork. |
There was a problem hiding this comment.
@sneridagh this component is not on the list from the PLIP #4460.
Do want the volto-slate components, including this one, to be refactored as well? If so, then would you please update the list accordingly?
Co-authored-by: Steve Piercy <[email protected]>
|
@shiven16 what was the result of running tests locally? Why do you think the CI checks fail? See also Update your pull request from your fork. |
About This PR
This PR refactored:
from class based to function based component
Please review and provide feedback on my changes. I am committed to addressing any issues promptly.