-
-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add language independent field icon. #6298
Conversation
✅ Deploy Preview for plone-components canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iRohitSingh Please take note of the checks which failed on this PR. It looks like you need to:
- Add the changelog
- Update test snapshots
- Update i18n
packages/volto/src/components/manage/Widgets/FormFieldWrapper.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Language and news look good. There are some failing tests to investigate.
Ok. I am investigating it. |
packages/volto/src/components/manage/Widgets/FormFieldWrapper.jsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks ready to me. @plone/volto-team Can we merge this for Volto 18?
Left an accessibility improvement comment regarding associating the message with the field that we should make, but we can likely fix that as non-breaking later on. LGTM |
@iRohitSingh @davisagli this is not so easy to test given the multilingual setup need, can we get some screenshots of this feature in action? |
@ichim-david Sure, here are a couple screenshots from our project: (That makes me realize that we should use a popup component instead of a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix #6297