Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language independent field icon. #6298

Merged
merged 5 commits into from
Sep 28, 2024
Merged

Conversation

iRohitSingh
Copy link
Contributor

Fix #6297

Copy link

netlify bot commented Sep 18, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 793ade8
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/66f123abb0b2b50008b6363b

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iRohitSingh Please take note of the checks which failed on this PR. It looks like you need to:

  1. Add the changelog
  2. Update test snapshots
  3. Update i18n

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Language and news look good. There are some failing tests to investigate.

@iRohitSingh
Copy link
Contributor Author

Language and news look good. There are some failing tests to investigate.

Ok. I am investigating it.

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ready to me. @plone/volto-team Can we merge this for Volto 18?

@JeffersonBledsoe
Copy link
Member

JeffersonBledsoe commented Sep 24, 2024

Left an accessibility improvement comment regarding associating the message with the field that we should make, but we can likely fix that as non-breaking later on. LGTM
Edit: Had some weird GitHub issues, review is below now

@ichim-david
Copy link
Member

@iRohitSingh @davisagli this is not so easy to test given the multilingual setup need, can we get some screenshots of this feature in action?

@davisagli
Copy link
Member

@ichim-david Sure, here are a couple screenshots from our project:

With sidebar expanded:
Screenshot 2024-09-25 at 1 13 54 PM

(That makes me realize that we should use a popup component instead of a title attribute, so that it can be accessed on a touch device.)

Things get a bit cramped when the sidebar is not expanded:
Screenshot 2024-09-25 at 1 14 16 PM

Copy link
Contributor

@pnicolli pnicolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pnicolli pnicolli merged commit 51375d5 into main Sep 28, 2024
71 checks passed
@pnicolli pnicolli deleted the language-independent-field branch September 28, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visually indicate that a field is a language independent field.
7 participants