-
-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: issue 3438 #6748
base: main
Are you sure you want to change the base?
Fix: issue 3438 #6748
Conversation
|
✅ Deploy Preview for plone-components canceled.
|
- See broken example at #6748 (comment) This PR does not need a changelog, as it's a follow up to #6613
ContextI have added the logic for the different use cases. In the test file for this component (packages/volto/src/components/theme/View/EventDatesInfo.test.jsx), Even though the texts are the same, they still have problems in the automated tests. It is because we should also have a To fix:
Is the code clear enough? :) please let me know! |
You need to run
Regarding the automated test errors, some of them are just whitespace things, that can be solved updating the snapshot (delete the file and run the tests to regenerate them). In the other cases, where different HTML is outputed, I would try to keep the new HTML the same as the previous one, if possible. The working of the new So big +1 for me, but you need to check the HTML produced by the new component. |
Caution
The Volto Team has suspended its review of new pull requests from first-time contributors until the release of Plone 7, which is preliminarily scheduled for the second quarter of 2026.
Read details.
If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.
Closes #