fix: block chooser position in experimental.addBlockButton #6751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plone-components canceled.
|
ichim-david
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
@giuliaghisini you've misspelled bugfix this is why the changelog test is crashing. otherwise I agree with this change
stevepiercy
requested changes
Feb 13, 2025
Co-authored-by: Steve Piercy <[email protected]>
stevepiercy
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Renamed change log to 6751.bugfix to pass CI. Looks good now.
@ichim-david already provided technical review. As soon as this is green, please merge. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem: with
config.experimental.addBlockButton.enabled=true prop
the placement of block chooser was wrong sometimes and search bar or some portion of block ckooser was not visible and usable (expecially when you have a lot of blocks in a block chooser section). See the problem here:
old.mov
With this fix, block chooser will placed bottom to the block, without mentioned problems:
new.mov