Skip to content

Fork razzle into @plone/razzle#7542

Merged
sneridagh merged 34 commits intomainfrom
volto-razzle
Nov 19, 2025
Merged

Fork razzle into @plone/razzle#7542
sneridagh merged 34 commits intomainfrom
volto-razzle

Conversation

@wesleybl
Copy link
Member

@wesleybl wesleybl commented Oct 22, 2025 •
edited by sneridagh
Loading

It's a fork of Razzle. Razzle is no longer maintained. So with this fork, we can update versions of packages with vulnerabilities.

I used the master branch of razzle

It also includes:

📚 Documentation preview 📚: https://volto--7542.org.readthedocs.build/

@wesleybl wesleybl marked this pull request as draft October 22, 2025 22:30
@wesleybl
Copy link
Member Author

wesleybl commented Oct 23, 2025

@davisagli @sneridagh in this case do we need to fix the lint or can we ignore it?

davisagli
davisagli reviewed Oct 23, 2025
View reviewed changes
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this case do we need to fix the lint or can we ignore it?

In my opinion we need to either apply the fixes, or change the lint configuration for this package so the existing code doesn't fail the checks.

@wesleybl
Copy link
Member Author

wesleybl commented Oct 23, 2025

In my opinion we need to either apply the fixes

@davisagli fixed.

@wesleybl
Copy link
Member Author

wesleybl commented Oct 23, 2025

@davisagli Is this considered a breaking change? Could we have this in Volto 18?

@davisagli
Copy link
Member

davisagli commented Oct 23, 2025

@wesleybl It's definitely a breaking change, since it requires updating babel.js and the storybook script. I wouldn't try to push it for Volto 18 unless something is actively broken with the existing razzle package.

@wesleybl wesleybl marked this pull request as ready for review October 23, 2025 17:32
stevepiercy
stevepiercy requested changes Oct 23, 2025
View reviewed changes
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just formatting and MyST markup stuff. Otherwise LGTM! Let's make sure it builds correctly in the PR preview at https://volto--7542.org.readthedocs.build/7542/upgrade-guide/index.html#replace-razzle-with-volto-razzle-fork

@wesleybl wesleybl requested a review from stevepiercy October 23, 2025 21:16
stevepiercy
stevepiercy approved these changes Oct 23, 2025
View reviewed changes
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs LGTM!

sneridagh
sneridagh reviewed Oct 25, 2025
View reviewed changes
Copy link
Member

@sneridagh sneridagh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks already very good!

@wesleybl wesleybl requested a review from sneridagh October 29, 2025 17:46
@wesleybl
Remove mini-css-extract-plugin from peerDependencies
3cfe9b8 
When using pnpm 9, and having mini-css-extract-plugin as a peerDependencie, it causes an error in the Volto build:

    Error: You forgot to add 'mini-css-extract-plugin' plugin

The cookieplone job still uses pnpm 9. Therefore, we cannot have it as a peerDependencie for now.
@wesleybl
Merge branch 'main' into volto-razzle
4873f2f
@wesleybl
Add mini-css-extract-plugin@2.7.2 as peerDependencie
b44e791
@wesleybl
Copy link
Member Author

wesleybl commented Nov 13, 2025

@davisagli @sneridagh I think this is ready. Could you please take a look?

stevepiercy
stevepiercy reviewed Nov 16, 2025
View reviewed changes
@sneridagh @stevepiercy
Update docs/source/upgrade-guide/index.md
72e3a01 
Co-authored-by: Steve Piercy <web@stevepiercy.com>
sneridagh
sneridagh reviewed Nov 16, 2025
View reviewed changes
sneridagh
sneridagh reviewed Nov 16, 2025
View reviewed changes
sneridagh
sneridagh reviewed Nov 16, 2025
View reviewed changes
@sneridagh
Copy link
Member

sneridagh commented Nov 16, 2025

Still undecided about the @volto namespace. We don't have any package with this name... I am wondering if we should just go with @plone namespace.

/cc @plone/volto-team

wesleybl and others added 2 commits November 17, 2025 12:30
@wesleybl @sneridagh
Update docs/source/upgrade-guide/index.md
c2f528d 
Co-authored-by: Víctor Fernández de Alba <sneridagh@gmail.com>
@wesleybl @sneridagh
Update docs/source/upgrade-guide/index.md
b5d9295 
Co-authored-by: Víctor Fernández de Alba <sneridagh@gmail.com>
@wesleybl
Copy link
Member Author

wesleybl commented Nov 17, 2025

Still undecided about the @Volto namespace. We don't have any package with this name... I am wondering if we should just go with @plone namespace.

I don't see a problem in changing it to @plone

@sneridagh
Copy link
Member

sneridagh commented Nov 17, 2025

@plone/volto-team I think this is ready, let's wait for tomorrow's meeting to approve it.

@github-project-automation github-project-automation bot moved this from In Progress to Approved in Plone Documentation Nov 18, 2025
@stevepiercy stevepiercy moved this to In Progress in Plone Documentation Nov 18, 2025
@sneridagh
Merge branch 'main' into volto-razzle
b5d3fec 
* main:
  Fixed types for SchemaEnhancers (#7627)
  Grammar fixes for #7615 (#7621)
@sneridagh
Rename package to @plone/razzle
5f56632
@sneridagh sneridagh changed the title Add package @volto/razzle Fork razzle into @plone/razzle Nov 19, 2025
sneridagh and others added 2 commits November 19, 2025 10:27
@sneridagh @wesleybl @stevepiercy
Fork babel-razzle-preset into @plone/babel-razzle-preset (#7619)
13e5a47 
Co-authored-by: Wesley Barroso Lopes <wesleybl@gmail.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
@Abhishek-17h @sneridagh @stevepiercy
Remove Jest (#7624)
81f24c2 
Co-authored-by: Victor Fernandez de Alba <sneridagh@gmail.com>
Co-authored-by: Steve Piercy <web@stevepiercy.com>
@sneridagh sneridagh merged commit 78ec373 into main Nov 19, 2025
83 checks passed
@sneridagh sneridagh deleted the volto-razzle branch November 19, 2025 10:03
@github-project-automation github-project-automation bot moved this from Approved to Done in Plone Documentation Nov 19, 2025
sneridagh added a commit that referenced this pull request Nov 19, 2025
@sneridagh
Merge branch 'main' into adoptsassplugin
7a35d43 
* main:
  Fixed Basic select in components (#7632) (#7638)
  Fork `razzle` into `@plone/razzle` (#7542)
@wesleybl wesleybl mentioned this pull request Nov 25, 2025
Closed
@davisagli davisagli mentioned this pull request Nov 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sneridagh sneridagh sneridagh left review comments

@stevepiercy stevepiercy stevepiercy approved these changes

@davisagli davisagli Awaiting requested review from davisagli

Assignees

No one assigned

Labels

None yet

Projects

Plone Documentation
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wesleybl @davisagli @stevepiercy @sneridagh @Abhishek-17h