dcc: refactor input #3398
Open
dcc: refactor input #3398
+1,358
−19,967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoolADE85
force-pushed
the
feature/dcc-refactor-input
branch
from
2b47c08 to
5a49f13
Compare
KoolADE85
force-pushed
the
feature/dcc-refactor-input
branch
2 times, most recently
from
d7fa1ac to
01dac37
Compare
KoolADE85
force-pushed
the
feature/dcc-refactor-input
branch
from
01dac37 to
1653281
Compare
KoolADE85
commented
Aug 12, 2025
| values = str([v["value"] for v in prop_info["value"]]) | ||
| return f"pt.oneOf({values})" | ||
| values = [v["value"] for v in prop_info["value"] if v.get("value") is not None] | ||
| return f"pt.oneOf([{",".join(v for v in values)}])" |
There was a problem hiding this comment.
Fixes doubly-quoted strings in an enum of string literals
KoolADE85
force-pushed
the
feature/dcc-refactor-input
branch
2 times, most recently
from
ffdf944 to
99e0e91
Compare
KoolADE85
force-pushed
the
feature/dcc-refactor-input
branch
from
99e0e91 to
7ec85f3
Compare
KoolADE85
force-pushed
the
feature/dcc-refactor-input
branch
from
1b336c2 to
0c175f5
Compare
KoolADE85
force-pushed
the
feature/dcc-refactor-input
branch
from
4f6b763 to
4a81cbe
Compare
KoolADE85
force-pushed
the
feature/dcc-refactor-input
branch
from
2367abf to
11d7d36
Compare
KoolADE85
requested review from
T4rk1n,
ndrezn,
gvwilson and
emilykl
as code owners
T4rk1n
reviewed
Aug 22, 2025
| * | ||
| * See: https://dash.plotly.com/loading-states#check-loading-states-from-components | ||
| */ | ||
| function LoadingElement({children}: LoadingElementProps) { |
There was a problem hiding this comment.
There is already a LoadingElement in js form, do we need both?
There was a problem hiding this comment.
This one, in typescript, is a slightly different pattern. So once all the components are migrated, I will remove the js version of this.
There was a problem hiding this comment.
Ok, maybe we can consolidate both, the whole idea behind the LoadingElement was to remove code duplication between the different components where the only difference was the html tag used (so we take it as prop and createElement).
T4rk1n
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
dcc.Inputto be a function-component written in Typescript and with new CSS rules applied. (update dcc.Input #3386)Contributor Checklist
optionals
CHANGELOG.md