Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop failing npm ls calls #5921

Closed
wants to merge 2 commits into from
Closed

Drop failing npm ls calls #5921

wants to merge 2 commits into from

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Sep 3, 2021

npm ls complains about plotly forks after #5888 resulting in preversion script to fail.

npm-ls

While we could successfully bundle, this PR drops those from the build step.

@plotly/plotly_js

@archmoj archmoj added this to the v2.5.0 milestone Sep 3, 2021
@archmoj archmoj requested a review from alexcjohnson September 3, 2021 13:24
@archmoj
Copy link
Contributor Author

archmoj commented Sep 3, 2021

Hmm... actually npm v7 does not complain about this. So perhaps it is time to upgrade npm to v7 (and the node.js to v16)

@archmoj archmoj mentioned this pull request Sep 3, 2021
Merged
@archmoj archmoj closed this Sep 3, 2021
@archmoj archmoj deleted the no-npm-ls branch September 3, 2021 19:08
@archmoj archmoj mentioned this pull request Sep 6, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson Awaiting requested review from alexcjohnson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging this pull request may close these issues.
1 participant
@archmoj